Skip to content

refactor(core): Extract playground modal styles to separate file#5927

Open
antonis wants to merge 1 commit intomainfrom
antonis/playground-modal-refactor
Open

refactor(core): Extract playground modal styles to separate file#5927
antonis wants to merge 1 commit intomainfrom
antonis/playground-modal-refactor

Conversation

@antonis
Copy link
Copy Markdown
Contributor

@antonis antonis commented Mar 30, 2026

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Extract StyleSheet.create definitions from playground/modal.tsx into a new playground/modal.styles.ts file. This brings the file from 427 lines down to 287 — under the max-lines limit of 300 — and removes the oxlint-disable for max-lines.

No logic changes, only moving style definitions to a separate file.

💡 Motivation and Context

Follow-up from #5867 review comment suggesting the file could be refactored instead of keeping the max-lines disable.

💚 How did you test it?

  • yarn build passes
  • All 1179 tests pass (103 suites)
  • oxlint reports 0 errors, 0 warnings
  • oxfmt --check passes

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

Move StyleSheet definitions from modal.tsx into modal.styles.ts to
bring the file under the max-lines limit (427 → 287 lines) and
remove the oxlint-disable for max-lines.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 30, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • refactor(core): Extract playground modal styles to separate file by antonis in #5927
  • chore(deps): update CLI to v3.3.5 by github-actions in #5925
  • chore: Replace prettier with oxfmt by antonis in #5880
  • chore(deps): bump brace-expansion to ^5.0.5 by antonis in #5920
  • chore(deps): bump path-to-regexp to ^8.4.0 by antonis in #5919
  • chore: Migrate from ESLint to oxlint by antonis in #5867
  • chore(deps): bump yaml to ^2.8.3 by antonis in #5921
  • chore(deps): bump activesupport to >= 7.2.3.1 by antonis in #5922
  • fix(ci): Update validate-pr action to remove draft enforcement by stephanie-anderson in #5923
  • chore(deps): bump actions/checkout from 4 to 6 by dependabot in #5916
  • chore(deps): bump getsentry/craft from 2.25.0 to 2.25.2 by dependabot in #5918
  • chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.25.0 to 2.25.2 by dependabot in #5914
  • chore(deps): bump github/codeql-action from 4.34.1 to 4.35.1 by dependabot in #5917
  • chore(deps): bump dorny/paths-filter from 3.0.2 to 4.0.1 by dependabot in #5915
  • fix: Prevent script injection vulnerability in platform-check action by fix-it-felix-sentry in #5913
  • chore(ios): Upgrade clang-format from v20 to v22 by antonis in #5905
  • chore: Add PR validation workflow by stephanie-anderson in #5906
  • chore(deps): bump brace-expansion from 1.1.12 to 1.1.13 by dependabot in #5909
  • chore(deps): bump picomatch to fix ReDoS and method injection by antonis in #5900
  • chore(deps): update Android SDK to v8.37.1 by github-actions in #5884
  • fix(build): Update expo-handler sentry-android version in update script by antonis in #5904
  • fix(ios): synchronize RNSentryTimeToDisplay across main and bridge th… by huextrat in #5887
  • chore(deps): bump node-forge from 1.3.2 to 1.4.0 by dependabot in #5903
  • chore(deps): update Sentry Android Gradle Plugin to v6.3.0 by github-actions in #5902

Plus 1 more


🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against 023f8a7

@antonis antonis mentioned this pull request Mar 30, 2026
10 tasks
@antonis antonis marked this pull request as ready for review March 30, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant