refactor(core): Extract playground modal styles to separate file#5927
Open
refactor(core): Extract playground modal styles to separate file#5927
Conversation
Move StyleSheet definitions from modal.tsx into modal.styles.ts to bring the file under the max-lines limit (427 → 287 lines) and remove the oxlint-disable for max-lines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
Plus 1 more 🤖 This preview updates automatically when you update the PR. |
Contributor
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Extract
StyleSheet.createdefinitions fromplayground/modal.tsxinto a newplayground/modal.styles.tsfile. This brings the file from 427 lines down to 287 — under themax-lineslimit of 300 — and removes theoxlint-disableformax-lines.No logic changes, only moving style definitions to a separate file.
💡 Motivation and Context
Follow-up from #5867 review comment suggesting the file could be refactored instead of keeping the
max-linesdisable.💚 How did you test it?
yarn buildpassesoxlintreports 0 errors, 0 warningsoxfmt --checkpasses📝 Checklist
sendDefaultPIIis enabled🔮 Next steps