feat(logging): auto-enable structured_logging in Rails#2721
Merged
Conversation
Contributor
|
solnic
force-pushed
the
2715-remove-double-opt-in-for-logs-in-rails
branch
from
September 24, 2025 12:17
3fe30dc to
5fa0cbd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2721 +/- ##
==========================================
+ Coverage 97.29% 97.31% +0.01%
==========================================
Files 144 144
Lines 5665 5669 +4
==========================================
+ Hits 5512 5517 +5
+ Misses 153 152 -1
🚀 New features to boost your workflow:
|
solnic
force-pushed
the
2715-remove-double-opt-in-for-logs-in-rails
branch
2 times, most recently
from
September 24, 2025 13:58
f18b5b5 to
2b44976
Compare
solnic
marked this pull request as ready for review
September 24, 2025 14:40
Collaborator
Author
|
@sl0thentr0py feeling so-so about how I implemented it but it is the simplest thing that worked. The drawback is that I made |
sl0thentr0py
requested changes
Sep 24, 2025
solnic
force-pushed
the
2715-remove-double-opt-in-for-logs-in-rails
branch
from
September 25, 2025 09:03
2b44976 to
9e54a77
Compare
solnic
force-pushed
the
2715-remove-double-opt-in-for-logs-in-rails
branch
from
September 25, 2025 09:11
9e54a77 to
8177efb
Compare
When config.enable_logs is true, enable structured logging in Rails automatically too. Closes #2715
solnic
force-pushed
the
2715-remove-double-opt-in-for-logs-in-rails
branch
from
September 25, 2025 11:55
8177efb to
4404bb6
Compare
solnic
force-pushed
the
2715-remove-double-opt-in-for-logs-in-rails
branch
from
September 25, 2025 12:08
4404bb6 to
bcb4def
Compare
sl0thentr0py
approved these changes
Sep 25, 2025
sl0thentr0py
left a comment
Member
There was a problem hiding this comment.
small nit/leftover, otherwise 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When config.enable_logs is true, enable structured logging in Rails automatically too.
Closes #2715