feat(issues): Simplify shared issue event rendering#111769
Merged
Conversation
Replace the generic EventEntries component with a focused SharedEventContent component co-located with its only consumer, the shared issue details page. The old component had an isShare prop that was always true in practice, dead code branches for non-share rendering, and rendered components (EventContexts, EventSdk, EventDevice, etc.) for data the SharedEventSerializer never sends. The new component only renders what the backend actually provides: entries, evidence, packages, and user feedback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
Update SharedViewOrganization to match what SharedProjectSerializer actually provides: replace id (never sent) with name (always sent). Keep features optional for OrganizationContext compatibility. Also narrow SharedEventContent to accept only SharedViewOrganization, use the type explicitly in index.tsx, cast for OrganizationContext, and remove the now-unused isNotSharedOrganization utility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
EventEntry was only used by the shared issue view. Inline its switch logic as SharedEventEntry, drop dead branches (DEBUGMETA, SPANS), replace the heavy InterimSection error boundary fallback with ErrorBoundary mini, strengthen props by making group required, and use core layout components for the empty state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
scttcper
changed the title
scttcper
changed the title
github-actions
bot
added
the
Scope: Backend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
shashjar
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared/public issue view (
/share/issue/:id) used generic event components that were designed for the full issue details page. These components carried dead code paths, rendered sections for data the backend never sends, and pulled in heavy dependencies like the issue details context.This PR co-locates the rendering logic with the shared view, only renders what
SharedEventSerializeractually provides, and aligns theSharedViewOrganizationtype with the backend response.