ref(issues): Remove grouping store#115970
Open
scttcper wants to merge 4 commits into
Open
Conversation
The merged fingerprints tab was using a Reflux store even though every real caller lived in the same issue details area. This moves the endpoint query and local UI state into groupMerged so the feature owns its own data flow. The local model now matches the hashes endpoint response instead of carrying the old store's dead fields around. Co-authored-by: Codex GPT-5 <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.61% |
Remove the local provider/context now that the state only feeds a small component tree. The view owns the query and reducer hooks, then passes the few values the toolbar and rows need. Also drops a couple leftovers from the old store migration: the identity parser and the unused fingerprint argument on initial state. Co-authored-by: Codex GPT-5 <noreply@openai.com>
trim a few implementation-y assertions from the grouping store migration tests. The specs still cover the useful row state behavior and rendered merged fingerprints, without adding loading state coverage. Co-authored-by: Codex GPT-5 <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merged fingerprints tab was using a Reflux store even though every real caller lived in the same issue details area. This moves the endpoint query and local UI state into groupMerged so the feature owns its own data flow.
The local model now matches the hashes endpoint response instead of carrying the old store's dead fields around.