ref(snuba): Stop dropping deprecated spans dataset in reset_snuba#115973
Open
phacops wants to merge 1 commit into
Open
ref(snuba): Stop dropping deprecated spans dataset in reset_snuba#115973phacops wants to merge 1 commit into
phacops wants to merge 1 commit into
Conversation
The standalone `spans` storage is being removed from Snuba (getsentry/snuba#7955). Once that lands, `/tests/spans/drop` 404s and every Snuba-backed Sentry test fails at setup. Drop the now-defunct endpoint from the test fixture so this lands cleanly alongside the Snuba PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
JoshFerge
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
/tests/spans/dropfrom thereset_snubatest fixture so thematching Snuba PR can land cleanly.
The standalone
spansdataset/storage in Snuba isreadiness_state: deprecateand is being removed in getsentry/snuba#7955. Without thischange, every Snuba-backed Sentry test fails at setup because the
removed dataset makes
/tests/spans/dropreturn 404 and the fixture'sassert all(... status_code == 200 ...)flips to false.This change should land before or together with the Snuba PR.
Refs getsentry/snuba#7955
Agent transcript: https://claudescope.sentry.dev/share/sUX6tMR0k8BkW8MdTy2kMYcnEKXmBBWcPaOEkdpPmL8