fix(attachments): infer MIME type from filename when stored as octet-stream#115977
Merged
Conversation
…stream normalize_content_type treats application/octet-stream as a valid content type and returns it as-is, even when the filename has a recognized extension (e.g., screenshot.png). This causes the download endpoint to serve images as application/octet-stream, breaking consumers that rely on the Content-Type header. Treat application/octet-stream as equivalent to None so the filename-based mimetypes.guess_type fallback can run. Fixes #115976
loewenheim
approved these changes
May 21, 2026
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5b51516. Configure here.
- Use .lower() for case-insensitive MIME type comparison per RFC 2045 - Update test_individual_attachments expectations: foo.txt with application/octet-stream now correctly resolves to text/plain - Add test for case-insensitive octet-stream detection
elramen
approved these changes
May 21, 2026
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
normalize_content_typeinsrc/sentry/models/eventattachment.pytreatsapplication/octet-streamas a valid explicit content type, so filename-based MIME inference viamimetypes.guess_typeis never reached. This causes the attachment download endpoint to serve images (e.g.,screenshot.png) asapplication/octet-stream, breaking consumers that rely on theContent-Typeheader to process the file.Change
Treat
application/octet-streamas equivalent toNoneinnormalize_content_type, allowing the existingmimetypes.guess_type(name)fallback to infer the correct MIME type from the filename.Files changed
src/sentry/models/eventattachment.py— 2-line fix innormalize_content_typetests/sentry/models/test_eventattachment.py— 6 new unit tests covering the functionFixes #115976