fix(autofix): Prevent loading spinner clip in artifact loading card#115988
Open
priscilawebdev wants to merge 1 commit into
Open
fix(autofix): Prevent loading spinner clip in artifact loading card#115988priscilawebdev wants to merge 1 commit into
priscilawebdev wants to merge 1 commit into
Conversation
The loading row of the autofix Root Cause / Solution / Code Changes cards rendered the spinner partially cut off at the bottom while streaming was in progress. Root cause: the inner scroll container is constrained vertically by a parent flex ancestor to the spinner's intrinsic height (16px), and `overflow-y: auto` removes the flex `min-height: auto` protection that would normally keep the container at content height. The adjacent `<Text>` defaults to `line-height: 19.6px`, so the row's content was 3px taller than the container — `useAutoScroll` then scrolled by exactly that 3px and clipped the top of the spinner. Setting `density="compressed"` on the `<Text>` (line-height 1) makes the text's content box match its font-size, so the row fits within the container and no overflow scroll is triggered.
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.60% |
TkDodo
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The loading row of the autofix Root Cause / Solution / Code Changes cards rendered the spinner partially cut off at the bottom while streaming was in progress.
Root cause: the inner scroll container is constrained vertically by a parent flex ancestor to the spinner's intrinsic height (16px), and
overflow-y: autoremoves the flexmin-height: autoprotection that would normally keep the container at content height. The adjacent<Text>defaults toline-height: 19.6px, so the row's content was 3px taller than the container —useAutoScrollthen scrolled by exactly that 3px and clipped the top of the spinner.Fix: set
density="compressed"on the<Text>(line-height: 1), so the text's content box matches its font-size and the row fits within the container — no overflow scroll triggered.Before
Screen.Recording.2026-05-21.at.14.20.23.mov
After
Screen.Recording.2026-05-21.at.14.31.23.mov