fix(perforce): Update onboarding frontend for Unicode support#116005
Open
mujacica wants to merge 2 commits into
Open
fix(perforce): Update onboarding frontend for Unicode support#116005mujacica wants to merge 2 commits into
mujacica wants to merge 2 commits into
Conversation
Contributor
mujacica
commented
May 21, 2026
mujacica
commented
- Update onboarding frontend for Unicode support
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.61% |
Comment on lines
+151
to
+156
| <field.Select | ||
| value={field.state.value} | ||
| onChange={field.handleChange} | ||
| options={CHARSET_CHOICES} | ||
| /> | ||
| </field.Layout.Stack> |
Member
There was a problem hiding this comment.
Are there going to be other options, seems like maybe this should just be a switch?
Unicode Server (UTF-8) and it's unticked by default?
Contributor
Author
There was a problem hiding this comment.
Yes there are more that we might want to support in the future - that's why the dropdown+enum - but I am fine going to checkbox until then if it's easier - I wanted to keep it aligned with other options here.
Member
There was a problem hiding this comment.
Let's do a checkbox, we can switch to choices in the future pretty easily, or if you really want you can have the backend take a choice and transform the value here on the frontend for the checkbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.