feat(cmdk): Add search keywords to reduce no-result queries#119056
Draft
cursor[bot] wants to merge 2 commits into
Draft
feat(cmdk): Add search keywords to reduce no-result queries#119056cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: Nicholas Meisenheimer <souredoutlook@users.noreply.github.com>
Drop project slug / SENTRY_ORG / SENTRY_PROJECT keywords that overlap with open PR #118642, keeping this change focused on the net-new token-creation and SDK-setup query clusters. Co-authored-by: Nicholas Meisenheimer <souredoutlook@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds keyword synonyms to command-palette (cmd+k) actions to eliminate two clusters of no-result searches surfaced by the Amplitude dashboard
ci7qhhad(chart Cmd+K: Top No-Result Queries, last 30 days).Each query below was verified against the
scoreNodefzf logic incommandPalette.tsx: fzf runs case-insensitively against each candidate string ([label, details, ...keywords]) independently, so a query only matches if it is a subsequence within a single string. I confirmed each targeted query did not match any existing candidate before, and now does, without adding redundant keywords (e.g.auth tokens,api key,SENTRY_AUTH_TOKEN,DSN,Client Keyswere already reachable and left untouched).Counts are anonymized aggregates over the last 30 days (summed across the reporting interval).
Changes
userOrgNavigationConfiguration)create token,create new token,create auth token,new tokencreate new tok(26),create tok(10),Create New Token(8)navigationConfiguration)sdk setup,sdk,setup,install,installationsdk setu(17),SDK Setup(13),setup(11),sdk(7)Why these targets:
create. These pages are where tokens are created, so they're the right destination.SDK Setupis only a settings section name (not a searchable item), sosdk/setupmatched nothing. Client Keys (DSN) is the primary SDK-setup page (the DSN is the core of SDK install), so it's the natural landing spot.Not addressed (and why)
master(auth tokens,api key,SENTRY_AUTH_TOKEN,DSN,Client Keys,Alerts— the latter matchesalert ruleson Create Alert).project slug,SENTRY_ORG,SENTRY_PROJECT,insights— already handled by the still-open PR feat(cmdk): Add search keywords to reduce no-result queries #118642, so intentionally not duplicated here.Testing
commandPaletteGlobalActions.spec.tsxsearch recallsuite forcreate new token,create token, andsdk setup. All 24 tests pass — they render the real palette and assert the actions surface.pnpm run lint:js <changed files>andpnpm run typecheckare green.No customer information is included; all Amplitude values are anonymized aggregate counts.