fix(dashboards): Show correct type badge for categorical bar X-axis attributes#119071
Open
gggritso wants to merge 1 commit into
Open
Conversation
…ttributes The categorical bar chart X-axis picker rendered a "tag" badge on every span attribute, including numeric ones, which is both wrong per-type and inconsistent with how Explore labels attributes. Drive the badge from each attribute's own kind so string attributes show "string", numeric ones "number", and booleans "boolean" — matching Explore's group-by and column-editor selectors (optionFromTag). Fixes DAIN-1765 Refs DAIN-1714 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1ef0337. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The categorical bar chart's X-axis picker rendered a
tagbadge on every span attribute, weird!The picker was hardcoding
<TypeBadge valueKind={FieldValueKind.TAG} />for every EAP attribute. Each attribute already carries its correctkind, so this drives the badge fromtag.kindinstead.Before:
After:
Fixes DAIN-1765