Skip to content

fix(github): Ungate inbound issue status sync from removed feature flag #119079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
souredoutlook wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −11
Open

fix(github): Ungate inbound issue status sync from removed feature flag #119079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/sentry/integrations/github/issue_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
from collections.abc import Mapping
from typing import Any

from sentry import features
from sentry.integrations.mixins.issues import IssueSyncIntegration, ResolveSyncAction
from sentry.integrations.models.external_actor import ExternalActor
from sentry.integrations.models.external_issue import ExternalIssue
Expand All @@ -27,13 +26,6 @@ class GitHubIssueSyncSpec(IssueSyncIntegration):
inbound_assignee_key = "sync_reverse_assignment"
resolution_strategy_key = "resolution_strategy"

def check_feature_flag(self) -> bool:
"""
A temporary method so we can gate Github & Github Enterprise project management features.
"""
ff_key = f"organizations:integrations-{self.model.provider}-project-management"
return features.has(ff_key, self.organization)

def split_external_issue_key(
self, external_issue_key: str
) -> tuple[str, str] | tuple[None, None]:
Expand Down Expand Up @@ -203,9 +195,6 @@ def get_resolve_sync_action(self, data: Mapping[str, Any]) -> ResolveSyncAction:
Given webhook data, check whether the GitHub issue status changed.
GitHub issues only have open/closed state.
"""
if not self.check_feature_flag():
return ResolveSyncAction.NOOP

if data.get("action") == IssueEvenntWebhookActionType.CLOSED.value:
return ResolveSyncAction.RESOLVE
elif data.get("action") == IssueEvenntWebhookActionType.REOPENED.value:
Expand Down
Loading