Skip to content

ref(performance): Remove Transaction Summary's "Tags" tab #119080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjq wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ref(performance): Remove Transaction Summary's "Tags" tab #119080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions static/app/components/charts/heatMapChart.tsx
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions static/app/components/charts/series/heatMapSeries.tsx
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions static/app/router/routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1774,13 +1774,6 @@ function buildRoutes(): RouteObject[] {
import('sentry/views/performance/transactionSummary/transactionReplays')
),
},
{
path: 'tags/',
handle: {tab: TransactionSummaryTab.TAGS},
component: make(
() => import('sentry/views/performance/transactionSummary/transactionTags')
),
},
{
path: 'events/',
handle: {tab: TransactionSummaryTab.EVENTS},
Expand Down
19 changes: 0 additions & 19 deletions static/app/utils/analytics/performanceAnalyticsEvents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,17 +149,6 @@ export type PerformanceEventParameters = {
};
'performance_views.summary.tag_explorer.visit_tag_key': Record<string, unknown>;
'performance_views.summary.view_in_transaction_events': Record<string, unknown>;
'performance_views.tags.change_aggregate_column': {
value: string;
};
'performance_views.tags.change_tag': {
from_tag: string;
is_other_tag: boolean;
to_tag: string;
};
'performance_views.tags.interaction': Record<string, unknown>;
'performance_views.tags.jump_to_release': Record<string, unknown>;
'performance_views.tags.tags_tab_clicked': PageLayoutParams;
'performance_views.team_key_transaction.set': {
action: string;
};
Expand Down Expand Up @@ -295,12 +284,6 @@ export const performanceEventMap: Record<PerformanceEventKey, string | null> = {
'Performance Views: Transaction Summary status breakdown option clicked',
'performance_views.all_events.open_in_discover':
'Performance Views: All Events page open in Discover button clicked',
'performance_views.tags.change_aggregate_column':
'Performance Views: Tags page changed aggregate column',
'performance_views.tags.change_tag':
'Performance Views: Tags Page changed selected tag',
'performance_views.tags.jump_to_release':
'Performance Views: Tags Page link to release in table clicked',
'performance_views.team_key_transaction.set':
'Performance Views: Set Team Key Transaction',
'performance_views.trends.widget_interaction':
Expand All @@ -324,14 +307,12 @@ export const performanceEventMap: Record<PerformanceEventKey, string | null> = {
'Performance Views: Select Relative Breakdown',
'performance_views.mep.metrics_outcome': 'Performance Views: Metrics Outcome',
'performance_views.vitals.vitals_tab_clicked': 'Performance Views: Vitals tab clicked',
'performance_views.tags.tags_tab_clicked': 'Performance Views: Tags tab clicked',
'performance_views.events.events_tab_clicked': 'Performance Views: Events tab clicked',
'performance_views.spans.spans_tab_clicked': 'Performance Views: Spans tab clicked',
'performance_views.summary.view_in_transaction_events':
'Performance Views: View in All Events from Transaction Summary',
'performance_views.summary.open_issues':
'Performance Views: Open issues from transaction summary',
'performance_views.tags.interaction': 'Performance Views: Tag Page - Interaction',
'performance_views.vitals.filter_changed': 'Performance Views: Change vitals filter',
'performance_views.vitals.reset_view': 'Performance Views: Reset vitals view',
'performance_views.trends.change_parameter': 'Performance Views: Change Parameter',
Expand Down
88 changes: 0 additions & 88 deletions static/app/utils/performance/segmentExplorer/segmentExplorerQuery.tsx
View file
Open in desktop

This file was deleted.

84 changes: 0 additions & 84 deletions static/app/utils/performance/segmentExplorer/tagKeyHistogramQuery.tsx
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions static/app/utils/performance/segmentExplorer/tagTransactionsQuery.tsx
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions static/app/views/performance/newTraceDetails/traceHeader/breadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,17 +130,6 @@ function getPerformanceBreadCrumbs(
),
});
break;
case Tab.TAGS:
crumbs.push({
label: t('Tags'),
to: getBreadCrumbTarget(
normalizeUrl(
`/organizations/${organization.slug}/${transactionSummaryUrl}/tags`
),
location.query
),
});
break;
default:
crumbs.push({
label: t('Transaction Summary'),
Expand Down
11 changes: 0 additions & 11 deletions static/app/views/performance/transactionSummary/filter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import type {Theme} from '@emotion/react';
import type {Location} from 'history';

import {pickBarColor} from 'sentry/components/performance/waterfall/utils';
import {SpanOpBreakdown} from 'sentry/utils/fields';
import {decodeScalar} from 'sentry/utils/queryString';

import {decodeHistogramZoom} from './transactionOverview/latencyChart/utils';
Expand All @@ -17,16 +16,6 @@ export enum SpanOperationBreakdownFilter {
UI = 'ui',
}

export const SPAN_OPERATION_BREAKDOWN_FILTER_TO_FIELD: Partial<
Record<SpanOperationBreakdownFilter, string>
> = {
[SpanOperationBreakdownFilter.HTTP]: SpanOpBreakdown.SPANS_HTTP,
[SpanOperationBreakdownFilter.DB]: SpanOpBreakdown.SPANS_DB,
[SpanOperationBreakdownFilter.BROWSER]: SpanOpBreakdown.SPANS_BROWSER,
[SpanOperationBreakdownFilter.RESOURCE]: SpanOpBreakdown.SPANS_RESOURCE,
[SpanOperationBreakdownFilter.UI]: SpanOpBreakdown.SPANS_UI,
};

export function filterToField(option: SpanOperationBreakdownFilter) {
switch (option) {
case SpanOperationBreakdownFilter.NONE:
Expand Down
Loading
Loading