fix(dashboards): Fetch attributes while typing in categorical bar X-axis#119084
Open
gggritso wants to merge 2 commits into
Open
fix(dashboards): Fetch attributes while typing in categorical bar X-axis#119084gggritso wants to merge 2 commits into
gggritso wants to merge 2 commits into
Conversation
The categorical bar chart's X-axis picker loaded span attributes from the capped `/trace-items/attributes/` page and filtered it client-side only, so attributes beyond that page (e.g. `gen_ai.tool.name`) could never be selected even though they appear in Explore. Wire the picker's search input to a debounced server-side fetch, mirroring Explore's group by, so typing narrows the query with `substringMatch` and surfaces long-tail attributes. Keep the selected value pinned and show loading/empty feedback while searching. Refs DAIN-1964 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ccfab3a. Configure here.
Set `highlight: true` on the picker's search config so the matched substring of each option is visually highlighted while typing, matching every Explore attribute picker. Refs DAIN-1964 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Span attributes beyond the initial
/trace-items/attributes/response weren't showing up in the X-axis of a categorical bar chart widget because we weren't fetching them. The data fetching wasn't hooked up quite right, this PR amends this.Before:
After:
Closes DAIN-1964