fix(autofix): Fix Overlapping Feedback Attribution with Feedback#119086
Open
alexsohn1126 wants to merge 3 commits into
Open
fix(autofix): Fix Overlapping Feedback Attribution with Feedback#119086alexsohn1126 wants to merge 3 commits into
alexsohn1126 wants to merge 3 commits into
Conversation
The LoadingIndicator's outer wrapper carries a hardcoded margin: 6em auto
that the size prop doesn't override, so the small spinner rendered with a
huge margin. Pass style={{margin: 0}} to collapse it.
github-actions
Bot
added
the
Scope: Frontend
alexsohn1126
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in-progress feedback icon in
codeChangesCardrendered wrong: a huge spinner margin, and the icon column overflowing into the feedback attribution.LoadingIndicator'ssizeprop only shrinks the inner spinner; the outer.loadingwrapper keeps a hardcodedmargin: 6em auto. Passstyle={{margin: 0}}to collapse it.flex="0 0 28px"(flex-shrink: 0), so an icon wider than 28px couldn't shrink and overflowed centered into the adjacent attribution. Switch towidth="28px", which keeps the defaultflex-shrink: 1and sizes to content.Previously:
After:
completes CORE-273