ref(forms): Migrate admin user edit off JsonForm to scraps form#119183
Conversation
github-actions
Bot
added
the
Scope: Frontend
7bffa33 to
880bd5d
Compare
880bd5d to
67aa5c1
Compare
67aa5c1 to
1d326ae
Compare
1d326ae to
a95f81a
Compare
a95f81a to
21f7566
Compare
21f7566 to
82f3d1c
Compare
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
bugbot run |
c5c0520 to
3ee5916
Compare
Seed the detail query from the users list cache via placeholderData instead of initialData. Because placeholderData isn't written to the cache and keeps the query pending, the detail fetch always runs and the form only mounts once authoritative data has loaded — so switching users while the view stays mounted remounts the form with fresh values instead of showing the previous user's data. Move BreadcrumbTitle to the parent so it shows the placeholder name while loading and the detail name once resolved. Keep the detail setQueryData on mutation success so the breadcrumb updates without a refetch; the list uses staleTime: 0 and refreshes on its own.
3ee5916 to
cd9bd14
Compare
The update path reset the form from the submitted client payload while the cache was updated from the PUT response, so the form baseline could diverge from cached user data when the API normalizes fields. Reset from the response instead, matching the deactivate path.
16e1d1b to
65cd744
Compare
The migrated admin user search debounced navigation by recreating a lodash debounce whenever location.query changed, without cancelling pending timers. A leaked timer would fire with a stale location.query snapshot and spread it over the URL, clobbering newer state such as the status filter or pagination cursor set by a competing navigation. Replace the manual debounce with nuqs useQueryStates: it writes only the query, status, and cursor keys (no read-modify-write spread of the whole query), debounces the URL update via limitUrlUpdates, and updates state optimistically so typing stays responsive. The status filter keeps its push history entry while search continues to replace.
|
bugbot run |
| <Fragment> | ||
| <BreadcrumbTitle title={user ? user.name || user.email : t('Details')} /> | ||
| {isLoading || isPlaceholderData ? ( | ||
| <LoadingIndicator /> |
There was a problem hiding this comment.
Placeholder cache still shows spinner
Medium Severity
The detail query seeds placeholderData from the users list cache so the page can render immediately, but the UI treats isPlaceholderData like a loading state and keeps showing LoadingIndicator until the refetch finishes. List-cache hydration never drives the edit form, so navigation from the list still shows a spinner despite the cached user already being available.
Reviewed by Cursor Bugbot for commit 316393a. Configure here.
| </Alert> | ||
| </Alert.Container> | ||
| ) : ( | ||
| <AdminUserEditForm user={user} userEndpoint={userEndpoint} /> |
There was a problem hiding this comment.
Placeholder loading hides form
High Severity
The detail view treats isPlaceholderData like a full-page load and shows LoadingIndicator whenever list cache placeholder data is in use. That blocks the edit form during background refetch (against the instant-hydration goal) and, when the detail request returns 404, can keep the spinner up instead of the not-found alert because error handling never runs while placeholder data is active.
Reviewed by Cursor Bugbot for commit 316393a. Configure here.
| > | ||
| <JsonForm forms={[userEditForm]} /> | ||
| </Form> | ||
| <form.SubmitButton>{t('Save Changes')}</form.SubmitButton> |
There was a problem hiding this comment.
Save allowed without changes
Low Severity
The migrated form always enables Save Changes, but the previous Form used requireChanges, which kept submit disabled until something changed. Admins can now trigger a PUT with unchanged values.
Reviewed by Cursor Bugbot for commit 316393a. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 4 total unresolved issues (including 3 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4945bf7. Configure here.
| ...defaultFormOptions, | ||
| defaultValues: toFormValues(user), | ||
| validators: {onDynamic: schema}, | ||
| onSubmit: ({value}) => updateMutation.mutateAsync(value).catch(() => {}), |
There was a problem hiding this comment.
API field errors not shown
Medium Severity
Submit errors from the user update API are no longer mapped onto fields. The legacy Form applied responseJSON field errors (such as username already in use) via handleErrorResponse, but onSubmit only swallows the rejection and onError toasts detail or a generic message, so field-level validation failures are lost.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 4945bf7. Configure here.
2 participants
Migrates the admin user edit page (
/manage/users/:id/) off the legacyJsonForm/FormModelto the scraps form system, and rewrites the users list offResultGridonto TanStack Query so opening a user hydrates instantly from the list cache (no spinner or breadcrumb flicker).This form is not shown on SaaS
Before
After
