feat(GAL): Add idempotency key to publish functions#119534
Merged
Merged
Conversation
thetruecpaul
force-pushed
the
cpaul/act2act/idempotent_publish
branch
from
c44d404 to
f291887
Compare
github-actions
Bot
added
the
Scope: Backend
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
thetruecpaul
force-pushed
the
cpaul/act2act/idempotent_publish
branch
from
f291887 to
c0175fc
Compare
thetruecpaul
force-pushed
the
cpaul/act2act/idempotent_publish
branch
from
c0175fc to
9f3c7f0
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
kcons
reviewed
Jul 13, 2026
| actor_id=payload["actor_id"], | ||
| source=payload["source"], | ||
| data=payload["data"], | ||
| idempotency_key=payload.get("idempotency_key"), |
Member
There was a problem hiding this comment.
Yeah, we need the dup handling here.
kcons
reviewed
Jul 13, 2026
thetruecpaul
force-pushed
the
cpaul/act2act/idempotent_publish
branch
from
9f3c7f0 to
cfe21de
Compare
yuvmen
approved these changes
Jul 13, 2026
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cfe21de. Configure here.
| ) | ||
| except IntegrityError: | ||
| # Idempotency conflict; we treat this as a no-op. | ||
| pass |
Contributor
There was a problem hiding this comment.
Duplicate key still triggers processing
Medium Severity
After an idempotency IntegrityError, the handler still registers transaction.on_commit to run trigger_group_log_processing. A collision is meant to be a no-op for the publish path, but this schedules derived work (inline or async) even when no new log entry was written.
Reviewed by Cursor Bugbot for commit cfe21de. Configure here.
thetruecpaul
force-pushed
the
cpaul/act2act/idempotent_publish
branch
from
cfe21de to
aab5246
Compare
Intended to help prevent collisions on activity double-write and activity backfill (but may be useful overall!)
thetruecpaul
force-pushed
the
cpaul/act2act/idempotent_publish
branch
from
aab5246 to
c331b4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to help prevent collisions on activity double-write and activity backfill (but may be useful overall!)