fix(issue-stream): Dismiss the Recommended sort badge after a sort is chosen#119537
Merged
roggenkemper merged 1 commit intoJul 13, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
… chosen The new-feature badge on the sort dropdown trigger announcing the Recommended sort default showed whenever the current sort was Recommended, so users who explicitly selected Recommended (or switched away and back) kept seeing an announcement about a default they already knew about, along with "pick a different sort and we'll remember your choice" copy that no longer fit. Show the trigger badge only while no stored sort exists. Any explicit sort choice, including re-selecting Recommended, writes the stored sort and permanently dismisses it. Also hide it on view pages, where sort changes are no longer remembered. The badge on the Recommended option inside the dropdown menu is unchanged. Co-Authored-By: Claude <noreply@anthropic.com>
roggenkemper
force-pushed
the
roggenkemper/fix/recommended-sort-badge-dismiss
branch
from
62acb0c to
89ee151
Compare
shayna-ch
approved these changes
Jul 13, 2026
cvxluo
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new-feature badge on the sort dropdown trigger (shown behind
issue-stream-recommended-sort-default) announcing the Recommended sort default showed whenever the current sort was Recommended, so a user who explicitly selected Recommended — or switched away and came back — kept seeing "Issues now default to the Recommended sort. Pick a different sort and we'll remember your choice." indefinitely.The trigger badge now shows only while no stored sort exists, i.e. while the user is seeing Recommended because of the default rather than by choice. Any explicit sort selection, including re-selecting Recommended, writes the stored sort and permanently dismisses it — no new state needed. It is also hidden on view pages, where sort changes are no longer remembered (#119415), so the tooltip copy would be wrong.
The badge on the Recommended option inside the dropdown menu is unchanged and still always shows.