ref(api): correct release threshold response types#119925
Open
cvxluo wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
Scope: Backend
The status endpoint's documented types diverged from the serializer: threshold_type is serialized as a string name (not an int), the date field is emitted as date_added, and trigger_type has a fixed vocabulary. Add Literal name types at the constants owner, annotate the int-to-str maps with them, and align the docs example and test fixtures with the real payload shape. Co-authored-by: Claude <noreply@anthropic.com>
cvxluo
marked this pull request as ready for review
July 17, 2026 18:43
cvxluo
force-pushed
the
cvxluo/correct-release-threshold-response-types
branch
from
July 20, 2026 18:16
b79ef06 to
5d32c11
Compare
coolguyzone
approved these changes
Jul 20, 2026
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Looks good from a docs standpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some types in the release thresholds endpoint.