-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
chore(event formatter): add new event formatter to rpc #119938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a44433e
96cf815
4fe7b50
2b3a837
c57094a
fb423be
d82bf51
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,3 +28,13 @@ class Limits: | |
| max_spans_chars=5_000, | ||
| max_contexts_chars=5_000, | ||
| ) | ||
|
|
||
| # tighter caps for token-constrained callers; mirrors Seer's EVENT_FORMAT_LIMITS_LOW | ||
| LIMITS_LOW = Limits( | ||
| max_exceptions_chars=50_000, | ||
| max_stacktrace_chars=10_000, | ||
| max_breadcrumbs_chars=5_000, | ||
| max_single_breadcrumb_chars=500, | ||
| max_request_chars=2_000, | ||
| max_spans_chars=5_000, | ||
| ) | ||
|
Comment on lines
+33
to
+40
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The Suggested FixAdd the Prompt for AI AgentAlso affects:
Did we get this right? 👍 / 👎 to inform future reviews. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Low limits uncap contexts
Medium Severity
LIMITS_LOWomitsmax_contexts_chars, soformat_limits="low"leaves the Contexts section uncapped whileformat_limits="default"truncates at 5,000 characters. Token-constrained RPC callers can get larger formatted output under the low profile than under default on context-heavy events.Additional Locations (1)
src/sentry/seer/agent/tools.py#L2183-L2184Reviewed by Cursor Bugbot for commit d82bf51. Configure here.