fix(explore): Improve chart empty-state guard#120014
Conversation
|
PR iteration only works on pull requests created by Seer's Autofix agent. PRs that the Autofix Agent didn't create aren't eligible. This includes PRs created by the Coding Agent handoff and unrelated human PRs. |
a1ab322 to
eb2c1a4
Compare
Sentry Snapshot Testing
|
96c7de5 to
c7ab742
Compare
|
@sentry review |
|
This PR is mergeable. Seer unfortunately did not have context of other work-in progress so it made a change at the same time as another PR I'm working on in the same area. This is a good problem type for Seer, and Seer did appropriately diagnose this and choose a correct solution. It stumbled while iterating on this, and had to be guided. |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5318533. Configure here.
|
The PR description, as usual, is pretty bad. 500 words where 100 would do. |
TimeSeriesWidgetVisualizationexpects that the data it gets can be plotted. Caller components should guard against this case, and put up an appropriate empty state, probablyTimeSeriesWidgetVisualization.NoData. Explore wasn't guarding this state, so it relies on the default handling, which shows a vague error screen, and barfs up an error into Sentry. This PR adds the correct guard, which adds the proper empty state.Closes JAVASCRIPT-34B7