Skip to content

fix(explore): Improve chart empty-state guard#120014

Merged
gggritso merged 2 commits into
masterfrom
seer/fix/explore-chart-no-plottable-values
Jul 20, 2026
Merged

fix(explore): Improve chart empty-state guard#120014
gggritso merged 2 commits into
masterfrom
seer/fix/explore-chart-no-plottable-values

Conversation

@sentry

@sentry sentry Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

TimeSeriesWidgetVisualization expects that the data it gets can be plotted. Caller components should guard against this case, and put up an appropriate empty state, probably TimeSeriesWidgetVisualization.NoData. Explore wasn't guarding this state, so it relies on the default handling, which shows a vague error screen, and barfs up an error into Sentry. This PR adds the correct guard, which adds the proper empty state.

Closes JAVASCRIPT-34B7

@sentry
sentry Bot requested a review from a team as a code owner July 18, 2026 22:40
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 18, 2026
@gggritso

Copy link
Copy Markdown
Member

@sentry I just merged #119940 to master which creates a new pattern for this state, can you update this PR to use the code from that branch?

@sentry

sentry Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@gggritso

PR iteration only works on pull requests created by Seer's Autofix agent. PRs that the Autofix Agent didn't create aren't eligible. This includes PRs created by the Coding Agent handoff and unrelated human PRs.

@sentry sentry Bot changed the title fix(explore): Handle charts with no plottable values gracefully fix(explore-charts): Handle unplottable data gracefully in ChartVisualization Jul 20, 2026
@sentry
sentry Bot force-pushed the seer/fix/explore-chart-no-plottable-values branch from a1ab322 to eb2c1a4 Compare July 20, 2026 17:30
Comment thread static/app/views/explore/components/chart/chartVisualization.tsx Outdated
Comment thread static/app/views/explore/components/chart/chartVisualization.tsx Outdated
@sentry

sentry Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
0 0 0 0 451 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

Comment thread static/app/views/explore/components/chart/chartVisualization.tsx Outdated
@sentry sentry Bot changed the title fix(explore-charts): Handle unplottable data gracefully in ChartVisualization fix(explore): Broaden chart empty-state guard to prevent crashes Jul 20, 2026
@sentry
sentry Bot force-pushed the seer/fix/explore-chart-no-plottable-values branch from 96c7de5 to c7ab742 Compare July 20, 2026 18:53
Comment thread static/app/views/explore/components/chart/chartVisualization.tsx
@gggritso

Copy link
Copy Markdown
Member

@sentry review

Comment thread static/app/views/explore/components/chart/chartVisualization.tsx
@gggritso

Copy link
Copy Markdown
Member

This PR is mergeable. Seer unfortunately did not have context of other work-in progress so it made a change at the same time as another PR I'm working on in the same area.

This is a good problem type for Seer, and Seer did appropriately diagnose this and choose a correct solution. It stumbled while iterating on this, and had to be guided.

@gggritso

Copy link
Copy Markdown
Member

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 5318533. Configure here.

@gggritso gggritso added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jul 20, 2026
@gggritso

Copy link
Copy Markdown
Member

The PR description, as usual, is pretty bad. 500 words where 100 would do.

@gggritso gggritso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@gggritso gggritso changed the title fix(explore): Broaden chart empty-state guard to prevent crashes fix(explore): Improve chart empty-state guard Jul 20, 2026
@gggritso
gggritso merged commit e465775 into master Jul 20, 2026
89 of 91 checks passed
@gggritso
gggritso deleted the seer/fix/explore-chart-no-plottable-values branch July 20, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant