Skip to content

fix(eslint): Enable unicorn/filename-case eslint rule#120103

Merged
ryan953 merged 8 commits into
masterfrom
ryan953/eslint-unicorn-filename-case
Jul 20, 2026
Merged

fix(eslint): Enable unicorn/filename-case eslint rule#120103
ryan953 merged 8 commits into
masterfrom
ryan953/eslint-unicorn-filename-case

Conversation

@ryan953

@ryan953 ryan953 commented Jul 20, 2026

Copy link
Copy Markdown
Member

No description provided.

@ryan953
ryan953 requested a review from a team as a code owner July 20, 2026 18:05
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 20, 2026
sentry[bot]
sentry Bot reviewed Jul 20, 2026
View reviewed changes
Comment thread eslint.config.ts
cursor[bot]
cursor Bot reviewed Jul 20, 2026
View reviewed changes
Comment thread eslint.config.ts Outdated
@ryan953
ryan953 requested review from a team as code owners July 20, 2026 18:26
cursor[bot]
cursor Bot reviewed Jul 20, 2026
View reviewed changes
Comment thread eslint.config.ts
cursor[bot]
cursor Bot reviewed Jul 20, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 73e854c. Configure here.

Comment thread static/app/views/detectors/newSettings.tsx Outdated
sentry[bot]
sentry Bot reviewed Jul 20, 2026
View reviewed changes
Comment thread static/app/views/detectors/newSettings.tsx Outdated
@ryan953
fix(eslint): Disable filename-case for existing violations
25fc2c5 
Add /* eslint-disable unicorn/filename-case */ to files with non-camelCase
names, rename kebab-case .mdx docs to camelCase, and ignore shebang scripts
(which can't take an inline directive on line 1) in the rule config.
@ryan953
ryan953 requested review from a team as code owners July 20, 2026 18:56
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 20, 2026
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@github-actions

github-actions Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Story previews

Preview the stories changed in this PR on the Vercel deployment:

Preview deployment: https://sentry-748lgde8s.sentry.dev

@ryan953
fix(eslint): Rename kebab-case static files to camelCase
e2f93f5 
Rename kebab-case .ts/.tsx files under static/ to camelCase and update
their references (relative imports, the type-loader rspack alias path, and
the ios-device-list import). ESLint rule-id strings stay kebab-case; only
filenames and relative import specifiers change. Drops the now-obsolete
ignore entries for these files.

The __mocks__ files are left as-is since jest resolves them by package
name.
@ryan953

ryan953 commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

@cursor resolve merge conflicts

@cursor

cursor Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

I've successfully resolved the merge conflicts on your branch!

What was conflicting:
The file static/eslint/eslintPluginScraps/src/ast/extractor/index.ts had a conflict at the end where your branch added export statements for various extractors and utilities, while master had removed or never had them.

Resolution:
I kept the exports from your branch:

  • createStyledExtractor
  • createCssPropExtractor
  • createStylePropExtractor
  • createThemeTracker
  • decomposeValue

Changes committed and pushed:

  • Merged master into ryan953/eslint-unicorn-filename-case
  • Pushed the merge commit to the remote branch

Your PR is now up to date with master and the merge conflicts are resolved.

Open in Web Open in Cursor 

@cursoragent @ryan953
Merge branch 'master' into ryan953/eslint-unicorn-filename-case
12b640b 
Co-authored-by: Ryan Albrecht <ryan@ryanalbrecht.ca>
ryan953
ryan953 commented Jul 20, 2026
View reviewed changes
Comment thread static/eslint/eslintPluginScraps/src/ast/extractor/index.ts Outdated
@ryan953
ryan953 enabled auto-merge (squash) July 20, 2026 23:05
@ryan953
ryan953 merged commit e1fe3d9 into master Jul 20, 2026
76 checks passed
@ryan953
ryan953 deleted the ryan953/eslint-unicorn-filename-case branch July 20, 2026 23:12
@ryan953 ryan953 mentioned this pull request Jul 20, 2026
Closed
@sentry-release-bot sentry-release-bot Bot mentioned this pull request Jul 23, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentry sentry[bot] sentry[bot] left review comments
@cursor cursor[bot] cursor[bot] left review comments
@untitaker untitaker untitaker approved these changes
@natemoo-re natemoo-re natemoo-re approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ryan953 @untitaker @natemoo-re @cursoragent