Skip to content

fix(seer): Correct overview action pending and empty-state checks#120397

Merged
NicoHinderling merged 2 commits into
masterfrom
nh/fix/autofix-overview-followups
Jul 22, 2026
Merged

fix(seer): Correct overview action pending and empty-state checks#120397
NicoHinderling merged 2 commits into
masterfrom
nh/fix/autofix-overview-followups

Conversation

@NicoHinderling

Copy link
Copy Markdown
Contributor

List cards now drop the action placeholder as soon as the autofix state request resolves, instead of also waiting on the runs request, which only feeds the analysis prose and trigger badge. Focus mode (?id=) still waits for both requests before classifying the card, since merge evidence comes from the run's pull requests and classifying early could briefly mislabel a merged issue as awaiting review.

The empty-state copy also stops counting a forced project selection as an active filter. Page filters auto-select the org's only project in single-project orgs, so a truly empty overview showed "No autofix runs match your filters." even with no filtering possible. A selection now counts as a filter only when the org has more than one project, mirroring the page-filters force-select rule.

Both address review findings surfaced on #120294 after it merged.

List-mode overview cards get their section from the server, so the
primary action and live-status overlays need only the autofix state
query. Passing the combined enrichmentPending as the row's statePending
kept the action as a placeholder until the runs query also settled, so
cards sat actionless longer than necessary.

Wire the row's statePending to the state query alone, and only gate the
action behind both queries in focus mode, where the section is derived
from enrichment (which reads run.pullRequests for merged evidence) and
must not commit to a section while runs is in flight.

Claude-Session: https://claude.ai/code/session_01BmNGhiCGfPpuuc1ZyZnHBZ
Page filters auto-select the only project for single-project orgs, so
those users always have a non-empty selection.projects and were shown
"No autofix runs match your filters." on a truly empty page instead of
"No completed autofix runs yet."

Treat the project selection as an active filter only when the org has
more than one project, mirroring the enforceSingleProject forcing rule
in pageFilters/actions, so a forced selection no longer reads as a
deliberate filter.

Claude-Session: https://claude.ai/code/session_01BmNGhiCGfPpuuc1ZyZnHBZ
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 22, 2026
@NicoHinderling
NicoHinderling marked this pull request as ready for review July 22, 2026 21:40
Comment thread static/app/views/seerWorkflows/overview/sectionList.tsx
@NicoHinderling
NicoHinderling enabled auto-merge (squash) July 22, 2026 21:45
@NicoHinderling
NicoHinderling merged commit 77c3fc6 into master Jul 22, 2026
73 checks passed
@NicoHinderling
NicoHinderling deleted the nh/fix/autofix-overview-followups branch July 22, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants