ref(demangle): Add backward compat patch for swift demangler#981
Open
Dav1dde wants to merge 3 commits into
Open
ref(demangle): Add backward compat patch for swift demangler#981Dav1dde wants to merge 3 commits into
Dav1dde wants to merge 3 commits into
Conversation
Dav1dde
force-pushed
the
dav1d/swift-6.3.1-compat-patch
branch
from
23a026d to
42edc33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for the 6.3.1 upgrade in #980 restoring a removed test, which breaks with the upgrade.
With the upgrade support for
MetatypeParamsRemovedwas removed from the demangler, this was previously represented with amin the mangled string. This patch skips themmarker to keep the correctly demangle the rest of the string.This does break re-mangling of these strings, but symbolic does not expose any remangling functionality.
If this patch ever becomes a problem in the future, it may be removed, it's only required for compatibility with old compiler versions and we generally prefer staying compatible with recent compilers.