exec-file/exec-env: reset supplementary groups when changing user#2194
Open
felixfontein wants to merge 2 commits into
Open
exec-file/exec-env: reset supplementary groups when changing user#2194felixfontein wants to merge 2 commits into
felixfontein wants to merge 2 commits into
Conversation
Signed-off-by: Felix Fontein <felix@fontein.de>
sabre1041
reviewed
May 26, 2026
| uid, _ := strconv.Atoi(user.Uid) | ||
| gid, _ := strconv.Atoi(user.Gid) | ||
|
|
||
| err = syscall.Setgroups([]int{gid}) |
Contributor
There was a problem hiding this comment.
Are we looking to map the supplemental groups for the specified user or reset it so that it only contains the primary group?
Mapping could be accomplished by something similar to the following
groupIds, _ := user.GroupIds()
intGroupIds := make([]int, len(groupIds))
for i, gid := range groupIds {
intGroupIds[i], _ = strconv.Atoi(gid)
}
err = syscall.Setgroups(intGroupIds)
if err != nil {
log.Fatal(err)
}
Contributor
Author
There was a problem hiding this comment.
Ah, I missed user.GroupIds(). Yeah, that makes sense. I've changed it slightly so that it falls back to []int{gid} if GroupIds() returns an error.
Signed-off-by: Felix Fontein <felix@fontein.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.