Disable git auto-gc in benchmark fixtures#19
Merged
Conversation
Fixture generation runs hundreds of rapid commits, triggering a background gc --auto that can prune still-unreachable objects mid-run and corrupt the ODB. Seen as "invalid object / Error building trees" on commit and "eof before pack header" on push. Disable gc.auto and maintenance.auto for all fixture git commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Target the root cause of the intermittent
Benchmarkfailures: a backgroundgc --auto.Context
Fixture generation runs hundreds of rapid commits, which triggers a background
gc --auto. It can prune still-unreachable objects mid-run and corrupt the ODB, surfacing as "invalid object / Error building trees" (commit) or "eof before pack header" (push). The earlier--no-thin(PR #18) only covered the push path. Not reproducible locally, so this is validated by watching the Benchmark job stay green across repeated CI runs.Changes
fixtures.rs: run every fixture git command with-c gc.auto=0 -c maintenance.auto=false.