Repository navigation
fix: correct NuGet package tags - #45
Merged
Merged
Conversation
The provider csproj files used ${PackageTags}, which is not MSBuild
syntax, so the published nuspec contained the literal text. Use
$(PackageTags), tag the PostgreSQL package postgresql instead of
sql server, and tag the SQL Server package sqlserver: NuGet tags are
space-separated, so "sql server" was published as two tags.
Closes #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The provider csproj files used
${PackageTags}, which is not MSBuild syntax, so the published nuspec contained the literal text (<tags>${PackageTags} dapper sql server</tags>). The PostgreSQL package was also taggedsql server.Changes
${PackageTags}->$(PackageTags)in the Dapper, SQL Server and PostgreSQL csproj files.dapper;postgresql.dapper;sqlserverinstead ofdapper;sql server. NuGet tags are space-separated, sosql serverwas published as two tags,sqlandserver.Verification
Release build (0 warnings), tags read from each generated nuspec:
AspNetCore.DataProtection.CustomStorageaspnetcore dataprotection storage...Dapperaspnetcore dataprotection storage dapper...Dapper.PostgreSQLaspnetcore dataprotection storage dapper postgresql...Dapper.SQLServeraspnetcore dataprotection storage dapper sqlserverCloses #21