feat(yaml-diff): colourise diff output via ```diff fenced block#232
Merged
Conversation
GitHub PR comments can't render ANSI, so colour the semantic diff using the `diff` code-fence highlighter instead: switch the fence to ```diff, move dyff's indented go-patch `-`/`+` markers to column 0 (keeping the indent after the marker) so removed/added values render red/green, and emit each file header as `@@ <path> @@` for a coloured separator. The sed rewrite only reorders leading whitespace, so byte counts — and the per-file/total truncation caps computed earlier — are unchanged. dyff's own colour stays off (auto-off in CI); we rely purely on GitHub's syntax highlighting. Requested in giantswarm/roadmap#4121. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the
yaml-diffbot's semantic diff colourised in the PR comment, per giantswarm/roadmap#4121 (marians: "colour would really help to make changes stand out better").GitHub PR comments can't render ANSI, so we use the
```diffcode-fence highlighter instead:```to```diff— GitHub renders-lines red,+lines green,@@ … @@as a header.-/+, which the highlighter ignores. Asedmoves the marker to column 0 while keeping the original indent after it, so nesting stays visible and the colouring fires.@@ <path> @@for a coloured separator.The
sedonly reorders leading whitespace → byte counts are unchanged, so the per-file / total truncation caps are unaffected. dyff's own ANSI colour stays off (auto-off in CI); we rely purely on GitHub highlighting.Before / after
Before (plain fence):
After (
```diff, markers at col 0 → red/green in the GitHub UI):Test plan
/no_diffs_printingopt-out unaffected.🤖 Generated with Claude Code