[TEST] yaml-diff: real value change#134
Closed
weatherhog wants to merge 3 commits into
Closed
Conversation
Exercises the yaml-diff bot: a real value change with key order preserved. Expect dyff to show only the namespace change and yamllint to pass. Throwaway test PR for roadmap#4121.
Change a line of the embedded values text (not name/namespace, which dyff treats as resource identity). Expect a clean field-level diff on data.values. Throwaway test PR for roadmap#4121.
Temporary: references github-workflows feat/yaml-diff-color. Throwaway test PR.
|
Semantic YAML source diff — key reordering without value changes is ignored. Output@@ management-clusters/MC_NAME/organizations/ORG_NAME/workload-clusters/WC_NAME_OUT_OF_BAND_FLUX_APP/out-of-band/configmaps/configmap.yaml @@
/data/values
± value change in multiline text (one insert, one deletion)
- Encryption is possible here as well, but I am not encrypted atm.
+ Encryption is possible here as well, but I am not encrypted yet.
Suppress with |
Validation output log |
Rendered manifest diff output log |
Contributor
Author
|
Closing — throwaway Phase-1 verification PR for roadmap#4121. All the work it exercised is merged: the yaml-diff bot, the SOPS-exclusion fix (giantswarm/github-workflows#231), colour output (#232), and the CI extraction (#233 + #139). Key-ordering removal is in #140. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway test PR for the yaml-diff bot rollout — roadmap#4121. Do not merge; close after verifying.
What this tests
One ConfigMap value changed (
metadata.namespace: default→kube-system), key order preserved.Expected
yaml-diffbot comment showing only the namespace value change.validate/ yamllint passes (alphabetical order preserved).