[TEST] yaml-diff: opt-out via /no_diffs_printing#135
Closed
weatherhog wants to merge 2 commits into
Closed
Conversation
Exercises the yaml-diff bot opt-out: a real value change, but the PR body carries /no_diffs_printing so the bot should skip posting. Throwaway test PR for roadmap#4121.
Change a line of the embedded values text so there IS a real semantic diff to suppress. Bot should still post nothing because the PR body carries /no_diffs_printing. Throwaway test PR for roadmap#4121.
Validation output log |
Rendered manifest diff output log |
Contributor
Author
|
Closing — throwaway Phase-1 verification PR for roadmap#4121. All the work it exercised is merged: the yaml-diff bot, the SOPS-exclusion fix (giantswarm/github-workflows#231), colour output (#232), and the CI extraction (#233 + #139). Key-ordering removal is in #140. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway test PR for the yaml-diff bot rollout — roadmap#4121. Do not merge; close after verifying.
What this tests
A real value change (
metadata.namespace: default→monitoring) plus the opt-out command below. Thecheck-cmp-statejob greps the PR body for it and should skip the diff job./no_diffs_printing
Expected
yaml-diffbot comment (job skipped despite a real value change).validate/ yamllint passes.