[TEST] yaml-diff: per-file truncation (>5000 bytes)#138
Closed
weatherhog wants to merge 2 commits into
Closed
Conversation
Replaces data.values with ~120 lines so the dyff output exceeds the 5000-byte per-file cap. Expect the bot to truncate with "... (truncated, file diff exceeded 5000 bytes)". Throwaway test PR for roadmap#4121.
Temporary: references github-workflows feat/yaml-diff-color. Throwaway test PR.
|
Semantic YAML source diff — key reordering without value changes is ignored. Output@@ management-clusters/MC_NAME/organizations/ORG_NAME/workload-clusters/WC_NAME_OUT_OF_BAND_FLUX_APP/out-of-band/configmaps/configmap.yaml @@
/data/values
± value change in multiline text (one insert, one deletion)
- Test ConfigMap.
- Variable substitution still possible here.
- I am the ${cluster_name} cluster!
- I belong to the ${organization} org!
- Encryption is possible here as well, but I am not encrypted atm.
+ config_key_001: this is a deliberately long value number 001 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_002: this is a deliberately long value number 002 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_003: this is a deliberately long value number 003 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_004: this is a deliberately long value number 004 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_005: this is a deliberately long value number 005 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_006: this is a deliberately long value number 006 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_007: this is a deliberately long value number 007 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_008: this is a deliberately long value number 008 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_009: this is a deliberately long value number 009 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_010: this is a deliberately long value number 010 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_011: this is a deliberately long value number 011 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_012: this is a deliberately long value number 012 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_013: this is a deliberately long value number 013 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_014: this is a deliberately long value number 014 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_015: this is a deliberately long value number 015 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_016: this is a deliberately long value number 016 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_017: this is a deliberately long value number 017 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_018: this is a deliberately long value number 018 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_019: this is a deliberately long value number 019 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_020: this is a deliberately long value number 020 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_021: this is a deliberately long value number 021 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_022: this is a deliberately long value number 022 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_023: this is a deliberately long value number 023 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_024: this is a deliberately long value number 024 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_025: this is a deliberately long value number 025 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_026: this is a deliberately long value number 026 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_027: this is a deliberately long value number 027 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_028: this is a deliberately long value number 028 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_029: this is a deliberately long value number 029 used to make the dyff output exceed the per-file truncation cap of five thousand bytes
+ config_key_030: this is a deliberately long value number 030 used to make the dyff
... (truncated, file diff exceeded 5000 bytes)Suppress with |
Validation output log |
Rendered manifest diff output log |
Contributor
Author
|
Closing — throwaway Phase-1 verification PR for roadmap#4121. All the work it exercised is merged: the yaml-diff bot, the SOPS-exclusion fix (giantswarm/github-workflows#231), colour output (#232), and the CI extraction (#233 + #139). Key-ordering removal is in #140. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway test PR for the yaml-diff bot rollout — roadmap#4121. Do not merge; close after verifying.
What this tests
One ConfigMap's
data.valuesis replaced with ~120 lines (~18 KB), so the dyff output for this single file exceeds the 5000-byte per-file cap.Expected
yaml-diffbot comment shows the diff truncated with... (truncated, file diff exceeded 5000 bytes).