Code Review Bench PR #30531 - feat: Add conversation variable persistence layer#4

Closed

ketkarameya wants to merge 21 commits into

base_pr_30531_20260125_8413from

corrupted_pr_30531_20260125_8413

Commits on Jan 25, 2026

Added constructor-based DI for VariableAssigner v2 and wired the node factory to pass the ConversationVariableUpdater factory (the only non-VariablePool dependency), plus a unit test to verify the …

laipz8200
authored and
tomerqodo
committed
Updated to avoid the dict path and let the type checker enforce constructor args.

laipz8200
authored and
tomerqodo
committed
A new command for updating variables. (vibe-kanban 00377ffe)

laipz8200
authored and
tomerqodo
committed
Add a new persistent storage for handling Conversation Variables. (vibe-kanban 0941477f)

laipz8200
authored and
tomerqodo
committed
- fix(lint): replace `outputs.keys()` iteration in `api/core/app/layers/conversation_variable_persist_layer.py` to satisfy SIM118

laipz8200
authored and
tomerqodo
committed
- feat(graph-engine): enforce variable update value types with SegmentType validation and casting

laipz8200
authored and
tomerqodo
committed
- refactor(variable-assigner-v1): inline updated variable payload and drop common_helpers usage

laipz8200
authored and
tomerqodo
committed
- refactor(graph-engine): switch VariableUpdate.value to VariableUnion and remove value type validation

laipz8200
authored and
tomerqodo
committed
- refactor(variable-assigner): restore common_helpers updated-variable handling for v1/v2 process_data

laipz8200
authored and
tomerqodo
committed
- refactor(variable-assigner): drop updated outputs now that persistence reads from process_data

laipz8200
authored and
tomerqodo
committed
- chore(lint): run `make lint` (fails: dotenv-linter module missing after venv changes)

laipz8200
authored and
tomerqodo
committed
Revert "- refactor(graph-engine): switch VariableUpdate.value to VariableUnion and remove value type validation"

laipz8200
authored and
tomerqodo
committed
Revert "- feat(graph-engine): enforce variable update value types with SegmentType validation and casting"

laipz8200
authored and
tomerqodo
committed
Revert "A new command for updating variables. (vibe-kanban 00377ffe)"

laipz8200
authored and
tomerqodo
committed
- refactor(services): move ConversationVariableUpdaterImpl and factory out of core.workflow into `api/services/conversation_variable_updater.py`

laipz8200
authored and
tomerqodo
committed
- chore(lint): run `make lint` (fails: import linter error and dotenv-linter module missing)

laipz8200
authored and
tomerqodo
committed
- chore(import-linter): remove obsolete ignore for variable_assigner impl import in `api/.importlinter`

laipz8200
authored and
tomerqodo
committed
fix(core): guard conversation variable flush when no updates

laipz8200
authored and
tomerqodo
committed
fix(core): use system variable conversation_id and add custom updater error

laipz8200
authored and
tomerqodo
committed
fix(services): use Exception for conversation variable not found

laipz8200
authored and
tomerqodo
committed
update pr
tomerqodo
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code Review Bench PR #30531 - feat: Add conversation variable persistence layer#4

Code Review Bench PR #30531 - feat: Add conversation variable persistence layer#4
ketkarameya wants to merge 21 commits into
base_pr_30531_20260125_8413from
corrupted_pr_30531_20260125_8413

Commits on Jan 25, 2026

Added constructor-based DI for VariableAssigner v2 and wired the node factory to pass the ConversationVariableUpdater factory (the only non-VariablePool dependency), plus a unit test to verify the …

Updated to avoid the dict path and let the type checker enforce constructor args.

A new command for updating variables. (vibe-kanban 00377ffe)

Add a new persistent storage for handling Conversation Variables. (vibe-kanban 0941477f)

- fix(lint): replace `outputs.keys()` iteration in `api/core/app/layers/conversation_variable_persist_layer.py` to satisfy SIM118

- feat(graph-engine): enforce variable update value types with SegmentType validation and casting

- refactor(variable-assigner-v1): inline updated variable payload and drop common_helpers usage

- refactor(graph-engine): switch VariableUpdate.value to VariableUnion and remove value type validation

- refactor(variable-assigner): restore common_helpers updated-variable handling for v1/v2 process_data

- refactor(variable-assigner): drop updated outputs now that persistence reads from process_data

- chore(lint): run `make lint` (fails: dotenv-linter module missing after venv changes)

Revert "- refactor(graph-engine): switch VariableUpdate.value to VariableUnion and remove value type validation"

Revert "- feat(graph-engine): enforce variable update value types with SegmentType validation and casting"

Revert "A new command for updating variables. (vibe-kanban 00377ffe)"

- refactor(services): move ConversationVariableUpdaterImpl and factory out of core.workflow into `api/services/conversation_variable_updater.py`

- chore(lint): run `make lint` (fails: import linter error and dotenv-linter module missing)

- chore(import-linter): remove obsolete ignore for variable_assigner impl import in `api/.importlinter`

fix(core): guard conversation variable flush when no updates

fix(core): use system variable conversation_id and add custom updater error

fix(services): use Exception for conversation variable not found

update pr