lite: add scripts for local bundling#13756
Open
slarse wants to merge 1 commit into
Open
Conversation
slarse
force-pushed
the
GB-1451/lite-local-bundle-scripts
branch
from
20248b1 to
ac0c4d1
Compare
slarse
force-pushed
the
GB-1451/lite-local-bundle-scripts
branch
from
ac0c4d1 to
edd6aaf
Compare
slarse
commented
May 12, 2026
Comment on lines
+9
to
+10
| <key>com.apple.security.cs.disable-library-validation</key> | ||
| <true/> |
Contributor
Author
There was a problem hiding this comment.
Required to load the unsigned Electron runtime.
slarse
commented
May 12, 2026
| "@gitbutler/design-core", | ||
| "@tanstack/eslint-plugin-query", | ||
| "electron", | ||
| "@types/semver", |
Contributor
Author
There was a problem hiding this comment.
If I don't add this. dependency, linting gets angry when accessing updater.currentVersion.prerelease as its type is unknown. And then adding this, linting gets angry that there's an unused dependency and you gotta awkwardly use the type explicitly.
So I'll just ignore the dep and we get the type checking properly, without making the code awkward. Really rough edge of TypeScript.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Lite app tooling to support local Electron Builder bundling, plus small supporting changes for macOS signing and updater behavior.
Changes:
- Add
bundle-local/bundle-local-nightlyscripts for locally packaging Lite (including building@gitbutler/but-sdkfirst). - Introduce a macOS “local” entitlements plist for ad-hoc signed builds.
- Update updater logic to skip auto-update checks for
-devprerelease builds; add@types/semverand lockfile updates.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
pnpm-lock.yaml |
Adds @types/semver and updates the resolved dependency graph accordingly. |
knip.jsonc |
Suppresses Knip reporting for @types/semver in the Lite workspace. |
apps/lite/resources/entitlements.mac.local.plist |
Adds a local-only entitlements profile for macOS bundling. |
apps/lite/README.md |
Documents the new local bundling scripts and caveats (macOS signing, updater testing, optional but CLI bundling). |
apps/lite/package.json |
Adds the new bundling scripts and changes default versioning to a -dev prerelease. |
apps/lite/electron/src/updater.ts |
Skips update checks for dev prerelease builds and adds error handling around update checks. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Also sets some local-only settings, including: * `-dev` suffix on the version to be able to disable the updater for dev builds * Dev-only entitlements for macOS required to run the bundle
slarse
force-pushed
the
GB-1451/lite-local-bundle-scripts
branch
from
edd6aaf to
a16d74a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧢 Changes
Adds scripts to facilitate easy local bundling of the Lite app.