Stop throwing errors on post-commit hook#13774
Open
mtsgrd wants to merge 1 commit into
Open
Conversation
It would only lead to something daft like the preventing the commit editor from closing automatically.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the desktop app’s commit flows so post-commit hook failures don’t propagate as thrown errors, avoiding UI flows (like the commit editor closing) being blocked by hook execution outcomes.
Changes:
- Changed
runPostCommitHooks()to stop throwing on hook failure and to swallow exceptions. - Simplified post-commit hook invocation in commit drop handlers by removing now-unnecessary error branching.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/desktop/src/lib/git/hooksService.ts | Makes post-commit hook execution non-throwing; logs errors instead of propagating. |
| apps/desktop/src/lib/dragging/dropHandlers/commitDropHandler.ts | Removes special-case error handling around post-commit hooks since they no longer throw. |
Comment on lines
56
to
59
| } catch (e: unknown) { | ||
| chipToasts.removeChipToast(loadingToastId); | ||
| throw e; | ||
| console.error("Post-commit hook error:", e); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would only lead to something daft like the preventing the commit
editor from closing automatically.