Skip to content

Fix contributor reputation check comment deduping #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronpowell merged 2 commits into from
Jun 29, 2026
+15 −5
Merged

Fix contributor reputation check comment deduping #2150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80b95c1
Fix contributor check comment upsert behavior
aaronpowell Jun 29, 2026
7ded536
Potential fix for pull request finding
aaronpowell Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .github/workflows/contributor-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,17 +192,22 @@ jobs:
profile="${{ steps.results.outputs.profile }}"
cred="${{ steps.results.outputs.credential }}"
marker="<!-- agt-contributor-check -->"
comment_id=$(
comment_ids=$(
gh api "repos/${{ github.repository }}/issues/$number/comments" --paginate \
--arg marker "$marker" \
--jq '.[] | select(.user.login == "github-actions[bot]" and (.body | contains($marker))) | .id' \
| head -n 1
--jq '.[] | select(.user.login == "github-actions[bot]" and ((.body // "") | contains($marker))) | .id'
)
comment_id=$(printf "%s\n" "$comment_ids" | sed -n '1p')

if [ "$risk" != "MEDIUM" ] && [ "$risk" != "HIGH" ]; then
if [ -n "$comment_id" ]; then
gh api --method DELETE "repos/${{ github.repository }}/issues/comments/$comment_id" \
|| echo "Comment $comment_id could not be deleted; continuing because the comment may have already been removed or changed."
# Keep one canonical comment thread by removing all matching comments
# when risk drops below MEDIUM.
while IFS= read -r id; do
[ -z "$id" ] && continue
gh api --method DELETE "repos/${{ github.repository }}/issues/comments/$id" \
|| echo "Comment $id could not be deleted; continuing because the comment may have already been removed or changed."
done <<< "$comment_ids"
fi
exit 0
fi
Expand All @@ -226,6 +231,11 @@ jobs:

if [ -n "$comment_id" ]; then
gh api --method PATCH "repos/${{ github.repository }}/issues/comments/$comment_id" -f body="$body"
# Clean up any stale duplicates after updating the canonical comment.
printf "%s\n" "$comment_ids" | sed '1d' | while IFS= read -r id; do
[ -z "$id" ] && continue
gh api --method DELETE "repos/${{ github.repository }}/issues/comments/$id" >/dev/null 2>&1 || true
done
else
gh api --method POST "repos/${{ github.repository }}/issues/$number/comments" -f body="$body"
fi
Expand Down
Loading