Fix contributor check gh api marker argument error#2151
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the “Sync risk comment” step in the contributor reputation check workflow by removing the unsupported gh api --arg usage and moving marker parameterization into jq.
Changes:
- Replace
gh api --jq ... --arg ...with ajq --arg ...pipeline to avoidgh apimarker-argument failures. - Add duplicate-marker cleanup logic to delete extra matching comments and keep one canonical thread.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/contributor-check.yml |
Updates the risk comment sync logic to use jq --arg and adds duplicate comment cleanup. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Review details
Comments suppressed due to low confidence (1)
.github/workflows/contributor-check.yml:204
- The comment here says it is keeping one canonical comment thread, but the loop below deletes all matching marker comments when risk drops below MEDIUM. This is a documentation mismatch that could confuse future maintenance.
# Keep one canonical comment thread by removing all matching comments
# when risk drops below MEDIUM.
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.mainbranch for this pull request.Description
The contributor reputation check workflow failed in
Sync risk commentbecausegh apidoes not support--arg. That caused the step to exit before it could update or dedupe the marker comment.This update moves marker parameterization to
jq(jq -r --arg marker ...) while keeping the same comment matching logic.Type of Contribution
Additional Notes
N/A
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.