Skip to content

Commit 1689bc7

Browse files
committed
refactor: extract toSessionMetadata helper and fix Python type annotation
1 parent 47ec0b3 commit 1689bc7

2 files changed

Lines changed: 19 additions & 15 deletions

File tree

nodejs/src/client.ts

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1078,14 +1078,7 @@ export class CopilotClient {
10781078
}>;
10791079
};
10801080

1081-
return sessions.map((s) => ({
1082-
sessionId: s.sessionId,
1083-
startTime: new Date(s.startTime),
1084-
modifiedTime: new Date(s.modifiedTime),
1085-
summary: s.summary,
1086-
isRemote: s.isRemote,
1087-
context: s.context,
1088-
}));
1081+
return sessions.map(CopilotClient.toSessionMetadata);
10891082
}
10901083

10911084
/**
@@ -1127,13 +1120,24 @@ export class CopilotClient {
11271120
return undefined;
11281121
}
11291122

1123+
return CopilotClient.toSessionMetadata(session);
1124+
}
1125+
1126+
private static toSessionMetadata(raw: {
1127+
sessionId: string;
1128+
startTime: string;
1129+
modifiedTime: string;
1130+
summary?: string;
1131+
isRemote: boolean;
1132+
context?: SessionContext;
1133+
}): SessionMetadata {
11301134
return {
1131-
sessionId: session.sessionId,
1132-
startTime: new Date(session.startTime),
1133-
modifiedTime: new Date(session.modifiedTime),
1134-
summary: session.summary,
1135-
isRemote: session.isRemote,
1136-
context: session.context,
1135+
sessionId: raw.sessionId,
1136+
startTime: new Date(raw.startTime),
1137+
modifiedTime: new Date(raw.modifiedTime),
1138+
summary: raw.summary,
1139+
isRemote: raw.isRemote,
1140+
context: raw.context,
11371141
};
11381142
}
11391143

python/copilot/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1643,7 +1643,7 @@ async def list_sessions(self, filter: SessionListFilter | None = None) -> list[S
16431643
sessions_data = response.get("sessions", [])
16441644
return [SessionMetadata.from_dict(session) for session in sessions_data]
16451645

1646-
async def get_session_metadata(self, session_id: str) -> "SessionMetadata | None":
1646+
async def get_session_metadata(self, session_id: str) -> SessionMetadata | None:
16471647
"""
16481648
Get metadata for a specific session by ID.
16491649

0 commit comments

Comments
 (0)