forward CustomAgentsLocalOnly in session.create and session.resume - #1899
Merged
roji merged 2 commits intoJul 31, 2026
Merged
Conversation
Collaborator
|
Thanks. I've pushed an additional commit on top that propagates this to all other language SDKs and also fixes the CustomAgentsLocalOnly behavior in Empty mode. |
roji
force-pushed
the
fix/dotnet-custom-agents-local-only-session-create
branch
from
July 17, 2026 11:01
8fad5ce to
a8726db
Compare
roji
enabled auto-merge
July 17, 2026 11:02
Collaborator
|
@github/copilot-sdk can someone give this a look please? |
…ion.resume CustomAgentsLocalOnly was only sent via the post-create session.options.update call, which arrives after agent discovery has already completed. Mirror the Go SDK by including customAgentsLocalOnly in CreateSessionRequest and ResumeSessionRequest wire payloads. Fixes github#1888
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6c5ceca0-342a-4fe7-8f7f-55637324e2b2
SteveSandersonMS
force-pushed
the
fix/dotnet-custom-agents-local-only-session-create
branch
from
July 31, 2026 13:22
a8726db to
34f8e99
Compare
SteveSandersonMS
changed the title
SteveSandersonMS
approved these changes
Jul 31, 2026
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
Contributor
There was a problem hiding this comment.
Fix is correct, complete, and consistent across all 6 SDK languages. Verified via manual regression testing (Python, Node.js, Rust) and .NET build. The timing bug — customAgentsLocalOnly arriving too late via post-create session.options.update — is resolved by forwarding the field in the session.create/session.resume wire payloads, matching the existing Go SDK behavior. Rebased onto latest main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward
CustomAgentsLocalOnlyfromSessionConfig/ResumeSessionConfiginto the .NET SDK'ssession.createandsession.resumewire payloads.Motivation
Fixes #1888. Agent discovery runs during session initialization. The .NET SDK previously only sent
customAgentsLocalOnlyvia the post-createsession.options.updatecall, which arrives too late to restrict discovery to the working directory. The Go SDK already includes this field insession.create/session.resume.Changes
customAgentsLocalOnlyto internalCreateSessionRequestandResumeSessionRequestrecordsconfig.CustomAgentsLocalOnlyinCreateSessionAsyncandResumeSessionAsyncTests
dotnet test test/GitHub.Copilot.SDK.Test.csproj --filter FullyQualifiedName~GitHub.Copilot.Test.Unit— 155 passedcustomAgentsLocalOnly— passedClientOptionsE2ETests; requiretsxin CI)Notes
session.options.updatebehavior is unchanged; this only ensures the value is present at initialization time.Fixes #1888