[Java] Task 4.1: Convert single-module java/ into multi-module Maven reactor - #2170
Conversation
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
…uild artifacts Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
edburns
left a comment
There was a problem hiding this comment.
@copilot Please fix the following issue:
CI Failure: Verify compiled workflows
The Check for uncommitted changes step reports these generated lock files are stale after their workflow source files were updated:
.github/workflows/java-adapt-handwritten-code-to-accept-upgrade-changes.lock.yml.github/workflows/java-codegen-fix.lock.yml.github/workflows/sdk-consistency-review.lock.yml
The run says: Lock files are out of date. Run 'gh aw compile' and commit the results.
Fix: Regenerate the affected agentic workflow lock files with gh aw compile, commit them, and ensure the compiled-workflows check is clean. Do not hand-edit the generated lock files.
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Ran |
edburns
left a comment
There was a problem hiding this comment.
@copilot The compiled-workflows check still fails because the lock files were generated with the wrong gh-aw compiler version.
CI Failure: Verify compiled workflows
Current committed lock metadata says compiler_version: v0.82.10, but CI compiles with v0.83.1 and produces a 12-file diff (568 insertions, 527 deletions), including all three relevant lock files.
Fix: Install/use gh-aw compiler v0.83.1, run gh aw compile with that exact version, and commit the resulting generated files. Confirm the committed lock metadata reports compiler_version: v0.83.1 and that compiling again with v0.83.1 leaves no diff. Do not use the currently installed v0.82.10 compiler.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Installed gh-aw v0.83.1 and regenerated all lock files. The committed metadata now reports |
edburns
left a comment
There was a problem hiding this comment.
@copilot The compiled-workflows check still fails because CI compiles with action pinning, while the committed output leaves github/gh-aw-actions/setup@v0.83.1 unpinned.
CI Failure: Verify compiled workflows
CI changes 13 files (105 insertions, 95 deletions). For example it changes:
uses: github/gh-aw-actions/setup@v0.83.1
to:
uses: github/gh-aw-actions/setup@8bdba8075360648fe6802302a5b4e016361dc6ac # v0.83.1
and updates the gh-aw-manifest SHA accordingly.
Fix: Reproduce the exact command/options used by .github/workflows/verify-compiled.yml (including action pinning), using gh-aw v0.83.1, commit the complete generated diff, then rerun that exact compile command and verify git diff is empty.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Added the |
edburns
left a comment
There was a problem hiding this comment.
@copilot The exact CI compile is now almost clean, but two generated files are still missing/outdated.
CI Failure: Verify compiled workflows
The latest run reports only:
.github/aw/actions-lock.json | 5 +++++
.github/workflows/agentics-maintenance.yml | 10 +++++-----
2 files changed, 10 insertions(+), 5 deletions(-)
Fix: Run the exact compile command from .github/workflows/verify-compiled.yml again on the current branch and commit both resulting files, including restoring the generated .github/aw/actions-lock.json entries. Then run the same command a second time and require an empty git diff before pushing.
This comment has been minimized.
This comment has been minimized.
…k files Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Added |
Cross-SDK Consistency Review ✅This PR restructures the Java module layout ( No cross-SDK consistency issues found. The changes are entirely build infrastructure and CI path updates — no public SDK APIs were added, modified, or removed. Other SDK implementations (Node.js, Python, Go, .NET, Rust) are unaffected and remain in parity.
|
Superseded: requested generated-workflow fixes are present and Verify compiled workflows passes on HEAD 89689c8.
1bf3396
into
edburns/1917-java-embed-rust-cli-runtime-dd-3039924-agentic-run-02
Converts
java/pom.xmlfrom a single-module build into a multi-module Maven reactor, moving the existing SDK into asdk/subdirectory while preserving its GAV (com.github:copilot-sdk-java) unchanged.Reactor structure
Future
copilot-nativeandcopilot-native-allmodules are declared in<modules>but commented out—reactor builds with justsdkuntil those tasks land.Key decisions
java/pom.xml): centralizespluginManagement(all plugin versions), shared properties, and setsmaven.deploy.skip=trueso only the SDK artifact is publishedcopilot.sdk.root: overridden insdk/pom.xmlas${project.basedir}/../..(monorepo root); cannot be inherited from parent because${project.basedir}evaluates in child contextsdk/pom.xmlreferences${project.parent.basedir}/scripts/codegensince scripts remain at the reactor rootREADME.md/jbang-example.java: moved tojava/sdk/becauseDocumentationSamplesTestresolves them viaPath.of("").toAbsolutePath()(Maven working dir = project basedir)Updated files
java/target/→java/sdk/target/; added-pl sdkflag where SDK-specific invocations are needed; path triggers updated forjava/sdk/src/generated/**java/scripts/codegen/java.ts: output pathsrc/generated/java/→sdk/src/generated/java/.gitignore: addedjava/sdk/target.mdfiles: alljava/src/path references updated tojava/sdk/src/