Fix AWF tool-cache mounting so Daily News Copilot can start in chroot#36900
Open
Copilot wants to merge 2 commits into
Open
Fix AWF tool-cache mounting so Daily News Copilot can start in chroot#36900Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix daily news workflow engine failure
Fix AWF tool-cache mounting so Daily News Copilot can start in chroot
Jun 4, 2026
Collaborator
|
@lpcox @salmanmkc self hosted issues on NVIDIA image |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes AWF chroot startup failures on hosted runners by ensuring the runner tool cache (e.g., /opt/hostedtoolcache) is always mounted into the AWF environment when present, so node (and other toolcache-provided runtimes) are available inside the chroot.
Changes:
- Updated AWF command generation to always mount
RUNNER_TOOL_CACHEwhen it exists (including/opt/hostedtoolcache). - Updated
daily-news.lock.ymlto apply the same mount-probe logic for both Copilot AWF invocations. - Tightened the AWF command unit test to assert the
/opt/*exclusion branch is no longer emitted.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/awf_helpers.go | Removes the /opt/* skip so the detected tool cache is always mounted read-only when present. |
| pkg/workflow/awf_config_test.go | Updates assertions to require mounting the detected tool cache path and to forbid the removed exclusion branch. |
| .github/workflows/daily-news.lock.yml | Syncs the workflow’s embedded mount probe with the helper behavior for both Copilot executions. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 0
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily News failed with a Copilot engine startup error (“terminated before producing output”). The failing run showed AWF chroot could not find
node, even though Node was installed via runner tool cache.Root cause
RUNNER_TOOL_CACHEwhen it was not under/opt/*./opt/hostedtoolcache), this skipped the mount, sonodewas unavailable inside chroot.AWF command generation update
RUNNER_TOOL_CACHEwhen it exists, including/opt/hostedtoolcache./home/runner/work/_toolwhenRUNNER_TOOL_CACHEis absent.Daily News lockfile update
daily-news.lock.ymlfor both Copilot AWF invocations so runtime behavior matches the helper fix.Regression guard
/opt/*exclusion branch and still emit mount injection.pr-sous-chef: update branch requested for run https://github.com/github/gh-aw/actions/runs/26979726834