Skip to content

Enforce canonical dispatch_repository safe-output key (remove dashed alias)#42150

Draft
Copilot wants to merge 5 commits into
mainfrom
copilot/doc-healer-fix-dash-alias
Draft

Enforce canonical dispatch_repository safe-output key (remove dashed alias)#42150
Copilot wants to merge 5 commits into
mainfrom
copilot/doc-healer-fix-dash-alias

Conversation

Copilot AI commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

dispatch_repository parsing had drifted from schema/docs by accepting an undocumented dashed alias (dispatch-repository). This change realigns runtime behavior with the declared contract by making underscore-only keying canonical.

  • Compiler behavior

    • Removed fallback lookup for safe-outputs.dispatch-repository in parseDispatchRepositoryConfig.
    • Compiler now recognizes only safe-outputs.dispatch_repository.
  • Workflow parsing coverage

    • Updated dispatch repository parser tests to assert dashed key rejection instead of acceptance.
  • Schema-level regression guard

    • Added parser validation coverage to ensure safe-outputs.dispatch-repository fails schema/location validation.
// before: accepted both keys
if configData, exists = outputMap["dispatch_repository"]; !exists {
    if configData, exists = outputMap["dispatch-repository"]; !exists {
        return nil
    }
}

// after: underscore-only
if configData, exists = outputMap["dispatch_repository"]; !exists {
    return nil
}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix dash alias in documentation for safe-outputs Enforce canonical dispatch_repository safe-output key (remove dashed alias) Jun 29, 2026
Copilot AI requested a review from pelikhan June 29, 2026 00:25
@github-actions

Copy link
Copy Markdown
Contributor

🤖 PR Triage — §28342769269

Field Value
Category bug
Risk low
Score 40/100
Priority medium
Action defer
Status Draft — awaiting promotion to ready

Score breakdown: Impact 20 · Urgency 8 · Quality 12

Rationale: Tiny targeted fix removing undocumented dashed alias from dispatch_repository parsing (+22/−9, 3 files). Enforces contract alignment between runtime and schema. Tests added. No CI yet. Currently draft — defer until promoted to ready.

i️ Promote to ready when complete and CI passes.

Generated by 🔧 PR Triage Agent · 107.8 AIC · ⌖ 10.9 AIC · ⊞ 5.4K ·

@github-actions

Copy link
Copy Markdown
Contributor

Great work on this one! 🎉 The dispatch_repository schema-alignment fix is clean, well-scoped, and easy to reason about.

  • Runtime change in dispatch_repository.go is minimal (1 addition, 5 deletions — surgical removal of the dashed fallback).
  • Test coverage is solid: existing parser tests updated to assert rejection of the dashed key, plus a new schema-level regression guard added in schema_location_test.go.
  • Description clearly explains the contract drift, the fix, and includes a readable before/after snippet.

This PR looks ready for review. 🟢

Generated by ✅ Contribution Check · 277.8 AIC · ⌖ 16.5 AIC · ⊞ 6K ·

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot align using dashes like other safe outputs

Copilot AI and others added 3 commits June 29, 2026 02:22
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@copilot align using dashes like other safe outputs

Implemented in e35808a (plus follow-ups f706b8f and 453e85c). dispatch-repository is now the canonical safe-output key (aligned with dashed naming), while dispatch_repository remains a backward-compatible alias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants