Skip to content

fix(canvas): move comment failures outside conversations #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasoppermann merged 2 commits into from
Oct 24, 2026
Merged

fix(canvas): move comment failures outside conversations #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5b5352
fix(canvas): move comment failures outside conversations
lukasoppermann Oct 24, 2026
b5c35ab
fix(canvas): refresh dependent Controls bundles
lukasoppermann Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/extensions/replica-prototype/assets/canvas-bridge.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .github/extensions/replica-prototype/assets/renderer-improvement-notes-prototype.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions .github/extensions/replica-prototype/assets/renderer-prototype-canvas-improvement-threads.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .github/extensions/replica-prototype/assets/renderer.css
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions .github/extensions/replica-prototype/assets/renderer.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .github/extensions/replica-prototype/marketplace.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ it("resolves the marketplace's relative source to the shipped plugin", async ()
)
const manifest = JSON.parse(await readFile(new URL(`${plugin.source}/plugin.json`, root)))
assert.equal(manifest.name, plugin.name)
assert.equal(manifest.version, "1.5.1")
assert.equal(manifest.version, "1.5.2")
const skill = await readFile(
new URL(`${plugin.source}/skills/replica-publish-prototype/SKILL.md`, root),
"utf8",
Expand Down
2 changes: 1 addition & 1 deletion .github/extensions/replica-prototype/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://agent-plugins.org/schemas/1.0.0/plugin.schema.json",
"name": "replica-prototype",
"description": "Wrap a running prototype with Replica publish controls and repository status.",
"version": "1.5.1",
"version": "1.5.2",
"author": {
"name": "GitHub"
},
Expand Down
2 changes: 1 addition & 1 deletion hub/.storybook/preview-fixtures/build-controls/controls.js
View file
Open in desktop

Large diffs are not rendered by default.

287 changes: 147 additions & 140 deletions hub/app/javascript/application/prototype-canvas/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { lazy, Suspense, useCallback, useLayoutEffect, useRef, useState } from "

import { AppDialogs } from "@features/prototype-canvas-dialogs"
import { BrowserBar } from "@components/prototype-browser-bar"
import { CanvasReviewFeedback } from "@components/canvas-review-feedback"
import { ControlsPanel } from "@components/prototype-controls-panel"
import type { ControlsPanelLayout } from "@components/prototype-controls-panel/types"
import { PrototypeCanvasHubPanel } from "@features/prototype-canvas-hub-panel"
Expand Down Expand Up @@ -242,151 +243,157 @@ export function App({ config }: Props) {
inert={sharing.state.open}
aria-hidden={sharing.state.open ? true : undefined}
>
<BrowserBar
address={address}
addressRef={addressRef}
canGoBack={navigation.index > 0}
canGoForward={navigation.index < navigation.entries.length - 1}
appearance={appearance}
onAppearanceChange={setAppearance}
onBack={() => travel(navigation.index - 1)}
onForward={() => travel(navigation.index + 1)}
onNavigate={navigate}
onOpenTab={async () => {
await request("/api/prototype/open", config.token, {
method: "POST",
body: JSON.stringify({ url: address }),
})
}}
onReload={reload}
/>
<CanvasReviewFeedback>
<BrowserBar
address={address}
addressRef={addressRef}
canGoBack={navigation.index > 0}
canGoForward={navigation.index < navigation.entries.length - 1}
appearance={appearance}
onAppearanceChange={setAppearance}
onBack={() => travel(navigation.index - 1)}
onForward={() => travel(navigation.index + 1)}
onNavigate={navigate}
onOpenTab={async () => {
await request("/api/prototype/open", config.token, {
method: "POST",
body: JSON.stringify({ url: address }),
})
}}
onReload={reload}
/>

<Toolbar
toolbarRef={toolbarRef}
improvementControlsRef={setImprovementControls}
config={config}
state={publication.presentedState}
prototypeName={
hub.status?.state === "connected" ? hub.status.prototype?.name || undefined : undefined
}
publishing={publication.busy}
publication={publication.publication}
publishButtonRef={publishButtonRef}
hubButtonRef={hubButtonRef}
titleButtonRef={titleButtonRef}
onBuildDetails={() => setBuildDetailsOpen(true)}
controlsButtonRef={controlsButtonRef}
controlsOpen={controlsOpen}
onControls={() => setControlsOpen(!controlsOpen)}
onPublish={() => void publication.publish()}
onShare={handleShare}
onImproveContext={canReviewFeedback ? () => void handleImproveContext() : undefined}
improvingContext={improvingContext}
feedbackMessage={feedbackMessage?.target === feedbackTarget ? feedbackMessage : undefined}
shareButtonRef={shareButtonRef}
hubOpen={hubOpen}
onHub={() => {
setHubOpen(!hubOpen)
void hub.refresh("interaction")
}}
/>
<Toolbar
toolbarRef={toolbarRef}
improvementControlsRef={setImprovementControls}
config={config}
state={publication.presentedState}
prototypeName={
hub.status?.state === "connected"
? hub.status.prototype?.name || undefined
: undefined
}
publishing={publication.busy}
publication={publication.publication}
publishButtonRef={publishButtonRef}
hubButtonRef={hubButtonRef}
titleButtonRef={titleButtonRef}
onBuildDetails={() => setBuildDetailsOpen(true)}
controlsButtonRef={controlsButtonRef}
controlsOpen={controlsOpen}
onControls={() => setControlsOpen(!controlsOpen)}
onPublish={() => void publication.publish()}
onShare={handleShare}
onImproveContext={canReviewFeedback ? () => void handleImproveContext() : undefined}
improvingContext={improvingContext}
feedbackMessage={
feedbackMessage?.target === feedbackTarget ? feedbackMessage : undefined
}
shareButtonRef={shareButtonRef}
hubOpen={hubOpen}
onHub={() => {
setHubOpen(!hubOpen)
void hub.refresh("interaction")
}}
/>

<iframe
key={frameKey}
ref={frameRef}
className="prototype-frame"
title={copy.prototypeFrameTitle(config.name)}
src={source}
style={{
colorScheme: appearance,
backgroundColor: "var(--hub-canvas-default)",
}}
/>
<iframe
key={frameKey}
ref={frameRef}
className="prototype-frame"
title={copy.prototypeFrameTitle(config.name)}
src={source}
style={{
colorScheme: appearance,
backgroundColor: "var(--hub-canvas-default)",
}}
/>

<PrototypeCanvasHubPanel
config={config}
active={reviewSurface === "comments"}
onActivate={() => setReviewSurface("comments")}
selectionDisabled={improvementInteraction}
onInteractionChange={setCommentInteraction}
frameRef={frameRef}
onRouteChange={reportRoute}
status={hub.status}
onStatusChange={hub.refresh}
onSelectHub={hub.select}
onConnect={connection.showAndConnect}
onDisconnected={connection.show}
connectionButtonRef={connectionButtonRef}
connecting={connection.connecting}
publication={publication.publication}
publicationBusy={publication.busy}
dirty={state?.stats.workingTree === "changed"}
onPublish={() => void publication.publish()}
onRetryPublication={() => void publication.retry()}
publishPreference={publishPreference}
open={hubOpen}
onClose={closeHub}
/>
<PrototypeCanvasHubPanel
config={config}
active={reviewSurface === "comments"}
onActivate={() => setReviewSurface("comments")}
selectionDisabled={improvementInteraction}
onInteractionChange={setCommentInteraction}
frameRef={frameRef}
onRouteChange={reportRoute}
status={hub.status}
onStatusChange={hub.refresh}
onSelectHub={hub.select}
onConnect={connection.showAndConnect}
onDisconnected={connection.show}
connectionButtonRef={connectionButtonRef}
connecting={connection.connecting}
publication={publication.publication}
publicationBusy={publication.busy}
dirty={state?.stats.workingTree === "changed"}
onPublish={() => void publication.publish()}
onRetryPublication={() => void publication.retry()}
publishPreference={publishPreference}
open={hubOpen}
onClose={closeHub}
/>

{config.improvementThreadsSample ? (
<Suspense fallback={<p role="status">{copy.improvementNotesLoading}</p>}>
<PrototypeCanvasThreadSample />
</Suspense>
) : config.pickAndPolish ? (
<Suspense
fallback={
<p className="visually-hidden" role="status">
{copy.improvementNotesLoading}
</p>
}
>
<ImprovementNotesPrototype
canvas={{
token: config.token,
frameRef,
toolbarTarget: improvementControls,
prototypeUrl: config.prototypeUrl,
previewUrl: config.previewUrl,
hubOpen,
active: reviewSurface === "improvements",
selectionDisabled: commentInteraction,
onInteractionChange: setImprovementInteraction,
onOpenNotes: () => {
setHubOpen(false)
setReviewSurface("improvements")
},
onNavigate: navigate,
}}
/>
</Suspense>
) : null}
{config.improvementThreadsSample ? (
<Suspense fallback={<p role="status">{copy.improvementNotesLoading}</p>}>
<PrototypeCanvasThreadSample />
</Suspense>
) : config.pickAndPolish ? (
<Suspense
fallback={
<p className="visually-hidden" role="status">
{copy.improvementNotesLoading}
</p>
}
>
<ImprovementNotesPrototype
canvas={{
token: config.token,
frameRef,
toolbarTarget: improvementControls,
prototypeUrl: config.prototypeUrl,
previewUrl: config.previewUrl,
hubOpen,
active: reviewSurface === "improvements",
selectionDisabled: commentInteraction,
onInteractionChange: setImprovementInteraction,
onOpenNotes: () => {
setHubOpen(false)
setReviewSurface("improvements")
},
onNavigate: navigate,
}}
/>
</Suspense>
) : null}

{controlsOpen && controls.connection && controlsState ? (
<ControlsPanel
state={controlsState}
connection={controls.connection}
layout={controlsLayout}
onLayoutChange={setControlsLayout}
diagnosisTarget={address}
onDiagnose={() =>
request("/api/controls/diagnose", config.token, {
method: "POST",
body: JSON.stringify({
status: controlsState.status,
runtimeAvailable: controlsState.runtimeAvailable,
reconnectRequired: controlsState.reconnectRequired === true,
hasError:
Boolean(controlsState.error) ||
controlsStatus(controlsState, controlsState.loading, address).controls.some(
(control) => control.visible && Boolean(control.error),
),
hasStorageError: Boolean(controlsState.storageError),
previewUrl: address,
}),
})
}
/>
) : null}
{controlsOpen && controls.connection && controlsState ? (
<ControlsPanel
state={controlsState}
connection={controls.connection}
layout={controlsLayout}
onLayoutChange={setControlsLayout}
diagnosisTarget={address}
onDiagnose={() =>
request("/api/controls/diagnose", config.token, {
method: "POST",
body: JSON.stringify({
status: controlsState.status,
runtimeAvailable: controlsState.runtimeAvailable,
reconnectRequired: controlsState.reconnectRequired === true,
hasError:
Boolean(controlsState.error) ||
controlsStatus(controlsState, controlsState.loading, address).controls.some(
(control) => control.visible && Boolean(control.error),
),
hasStorageError: Boolean(controlsState.storageError),
previewUrl: address,
}),
})
}
/>
) : null}
</CanvasReviewFeedback>
</main>

<div role="status" aria-live="polite" className="visually-hidden">
Expand Down
Loading
Loading