gh-1027: Use the official astral hook for ty#1133
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project’s type-checking workflow to run ty via the official astral-sh/ty-pre-commit hook again, simplifying the nox lint session to rely on prek/pre-commit for running checks.
Changes:
- Add the official
ty-pre-commithook and configure it to run with thelintdependency group. - Remove the explicit
ty checkinvocation from thenox -s lintsession and forwardnoxpositional args toprek. - Expand the
lintdependency group to include packages needed fortyto analyze the configured source set.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
pyproject.toml |
Expands the lint dependency group to support running ty via pre-commit/uv groups. |
noxfile.py |
Simplifies the lint session to run only prek (pre-commit hooks), with forwarded posargs. |
.pre-commit-config.yaml |
Adds the official astral-sh/ty-pre-commit hook and configures its execution flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jun 11, 2026
connoraird
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/astral-sh/ty-pre-commit finally exists. In #926 we migrated from
mypytoty. Some further work was done in #1091 to make it more reliable. Now we can go back to simplepre-commit. There are a fair amount of options to investigate.Closes: #1027
Changelog entry
Changed:
tyis now run throughpre-commitChecks