Rename 'set_subscription_admin_verified_id'#1302
Merged
Merged
Conversation
Remove the '_id' suffix, per discussion with the Groups team. The new name is 'set_subscription_admin_verified'. The old function is still available as an alias, but emits a `RemovedInV4Warning`. The test fixture data in `globus_sdk._testing` is slightly adjusted, but not considered a breaking change due to the looser compatibility policy around the provided fixtures.
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
MaxTueckeGlobus
approved these changes
Aug 28, 2025
Member
Author
|
I'm going to merge in spite of the CI failure because I think that RTD action is now broken. It's marked deprecated and we're supposed to migrate to the RTD app integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the '_id' suffix, per discussion with the Groups team.
The new name is 'set_subscription_admin_verified'.
The old function is still available as an alias, but emits a
RemovedInV4Warning.The test fixture data in
globus_sdk._testingis slightly adjusted, butnot considered a breaking change due to the looser compatibility policy
around the provided fixtures.
When this merges back to 4.x, I will need to apply a change to remove the
deprecated method and test for it.