Merge main into 4.x-dev#1306
Merged
derek-globus merged 9 commits intoSep 8, 2025
Merged
Conversation
Remove the '_id' suffix, per discussion with the Groups team. The new name is 'set_subscription_admin_verified'. The old function is still available as an alias, but emits a `RemovedInV4Warning`. The test fixture data in `globus_sdk._testing` is slightly adjusted, but not considered a breaking change due to the looser compatibility policy around the provided fixtures.
This build now fails for us with a message about action version pinning (presumably because we have enabled the requirement for hash versioning). Checking up on the action repo, it currently has a deprecation notice. After enabling PR builds via their new integration (a GitHub App), I am removing this build. We should continue to get PR builds, and if we do not we can investigate without "noise" from this failing build.
Bumps the github-actions group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 4.2.2 to 5.0.0 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@11bd719...08c6903) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com>
derek-globus
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
kurtmckee,
m1yag1 and
sirosen
as code owners
sirosen
approved these changes
Sep 8, 2025
Member
sirosen
left a comment
sirosen
left a comment
There was a problem hiding this comment.
Not sure if that pylint ignore was added here or previously, but I don't remember it being necessary. Suggests that something hinky is going on. I'll try to remember to look at it, but also... 🤷
Contributor
Author
I added it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging latest changes from main branch into 4.x-dev
📚 Documentation preview 📚: https://globus-sdk-python--1306.org.readthedocs.build/en/1306/