feat: [sc-47448] implement bookmark methods in Transfer v2 client#1379
Open
pjhinton-globus wants to merge 3 commits intoglobus:mainfrom
Open
feat: [sc-47448] implement bookmark methods in Transfer v2 client#1379pjhinton-globus wants to merge 3 commits intoglobus:mainfrom
pjhinton-globus wants to merge 3 commits intoglobus:mainfrom
Conversation
pjhinton-globus
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee,
m1yag1 and
sirosen
as code owners
Added the following methods to the experimental TransferClientV2: * create_bookmark() * update_bookmark() * get_bookmark() * delete_bookmark() * list_bookmarks() This provides access to the new Transfer v2 API operations for boomkark management, which includes support for high assurance collections. Functional unit tests are provided for all methods.
pjhinton-globus
force-pushed
the
pjhinton/sc-47448_transfer_v2_bookmark_sdk_support
branch
from
21271f9 to
cf0821c
Compare
kurtmckee
requested changes
Apr 9, 2026
src/globus_sdk/experimental/transfer_v2/data/bookmark_documents.py
Outdated
Show resolved
Hide resolved
This commit implements the following requested changes from @kurtmckee in his pull request review. use cross referencing modifier for method name for brevity globus#1379 (comment) fix docstring copy-and-paste typos and verify no other instances elsewhere globus#1379 (comment) look up class name rather than hard-coding in debug log statements globus#1379 (comment) add a missing f-prefix on log string with interpolation globus#1379 (comment)
kurtmckee
requested changes
Apr 9, 2026
src/globus_sdk/experimental/transfer_v2/data/bookmark_documents.py
Outdated
Show resolved
Hide resolved
Implements the following requested change from @kurtmckee. globus#1379 (comment)
kurtmckee
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shortcut Story: https://app.shortcut.com/globus/story/47448/
Added the following methods to the experimental TransferClientV2:
This provides access to the new Transfer v2 API operations for boomkark management, which includes support for high assurance collections.
Functional unit tests are provided for all methods. Change log entry is present.