Skip to content

Fix/internal buildable packages - #26

Merged
glypse merged 4 commits into
glypse:mainfrom
66HEX:fix/internal-buildable-packages
Jul 19, 2026
Merged

Fix/internal buildable packages#26
glypse merged 4 commits into
glypse:mainfrom
66HEX:fix/internal-buildable-packages

Conversation

@66HEX

@66HEX 66HEX commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

I’ve sorted out the configuration of the internal packages:

  1. $editor and $theme are now explicitly private,
  2. theme uses the sources from the dev environment and from dist in production,
  3. Nx caches the correct dist directories.

To be sure, I ran a benchmark on separate worktrees: 7 runs before the changes and 7 after. Previously, Nx reported a cache hit but didn’t restore any artifacts, and the production build failed every time (0/7). After the changes, the cache restores the entire dist, and the build succeeds on every attempt (7/7).

Checklist

  • Add a changeset (not applicable - internal packages and Nx configuration only)

@changeset-bot

changeset-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 92acb6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@glypse
glypse force-pushed the fix/internal-buildable-packages branch 4 times, most recently from 3fd9c25 to 7e475e1 Compare July 9, 2026 10:04
@glypse

glypse commented Jul 9, 2026

Copy link
Copy Markdown
Owner

Hey, as you might notice I'm having a hard time resolving those conflicts. Could you please rebase your branch onto the latest main? Thanks in advance.

@glypse
glypse force-pushed the fix/internal-buildable-packages branch from 337872b to 92acb6d Compare July 19, 2026 11:46
@glypse
glypse merged commit 8dc5a1a into glypse:main Jul 19, 2026
@glypse

glypse commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants