fix: #224#272
Open
Flipped199 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes requests for methods without parameters when using a self-hosted Telegram Bot API server.
Previously,
rawRequestalways created a multipart request body, even whenparamswas nil. That behavior appears to break some self-hosted Bot API implementations for parameterless methods such asgetMe.What changed
paramsis nilio.Pipeandmultipart.Writerwhen parameters are actually presentisNilhelper instead of callingreflect.Value.IsNil()directly on unsupported kindsWhy
This makes parameterless requests behave more like true empty-body HTTP requests instead of empty multipart form uploads.
It also avoids reflection panics for non-nilable value types.
Impact
Related
Fixes #224