fix: example avalue pointer bug + CI examples check (v0.5.5)#57
Merged
Conversation
Fix examples/simple/main.go: avalue elements must be pointers TO argument values (unsafe.Pointer(&cstr)), not values directly. The Darwin path was correct, Windows/Linux path was not. Add examples build verification to CI cross-compile job — iterates all examples/*/go.mod and runs go build.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/simple/main.go: avalue elements must be pointers TO argument values, not values directly. Darwin path was correct, Windows/Linux path was notexamples/*/go.modcompiled in cross-compile jobBug
Reported by @lkmavi on Windows 11 ARM64 (Snapdragon).
Test plan
examples/simple/compiles locallyCloses: reported via chat, no GitHub issue