Skip to content

Upgrade to ESLint 10 #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarkins-godaddy merged 16 commits into from
Mar 26, 2026
Merged

Upgrade to ESLint 10 #1297

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d575e38
Start upgrade to eslint 10
olafleur-godaddy Feb 24, 2026
b6734b0
eslint 10 in package.json
olafleur-godaddy Feb 24, 2026
7797e1a
Upgrade eslint-config-godaddy-typescript to eslint 10
olafleur-godaddy Feb 24, 2026
d94d8fe
Convert eslint-config-godaddy-react-typescript to eslint 10
olafleur-godaddy Feb 24, 2026
cd20e7d
Upgrade @babel/eslint-parser
olafleur-godaddy Feb 24, 2026
c346bb2
@eslint/js v10
olafleur-godaddy Feb 24, 2026
bd66283
Upgrade @eslint/eslintrc
olafleur-godaddy Feb 24, 2026
7b2320e
Changeset
olafleur-godaddy Feb 24, 2026
e4d2eea
Try to fix tests
olafleur-godaddy Feb 24, 2026
3c52220
Changes brought up in code review
olafleur-godaddy Feb 25, 2026
db80c4c
Merge branch 'main' into compat-with-eslint10
olafleur-godaddy Feb 25, 2026
4aaed84
Merge branch 'main' into compat-with-eslint10
olafleur-godaddy Feb 26, 2026
abb35f2
Forgotten one update to eslint
olafleur-godaddy Feb 26, 2026
851f99c
Merge branch 'main' into compat-with-eslint10
olafleur-godaddy Mar 6, 2026
c8f5b2f
Merge branch 'main' into compat-with-eslint10
olafleur-godaddy Mar 24, 2026
4515e63
Merge branch 'main' into compat-with-eslint10
olafleur-godaddy Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/two-coins-allow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"eslint-config-godaddy-react-typescript": major
"eslint-config-godaddy-typescript": major
"eslint-config-godaddy-react": major
"eslint-config-godaddy": major
---

Upgrade to ESLint 10
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
},
"devDependencies": {
"@changesets/cli": "^2.29.5",
"@eslint/eslintrc": "^3.3.1",
"@eslint/eslintrc": "^3.3.4",
"@eslint/js": "^9.24.0",
Comment thread
olafleur-godaddy marked this conversation as resolved.
Outdated
"@typescript-eslint/eslint-plugin": "^8.35.0",
"@typescript-eslint/parser": "^8.30.1",
Expand Down
8 changes: 4 additions & 4 deletions packages/eslint-config-godaddy-react-typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,17 @@
],
"license": "MIT",
"dependencies": {
"@typescript-eslint/eslint-plugin": "^8.35.0",
"@typescript-eslint/parser": "^8.30.1",
"@typescript-eslint/eslint-plugin": "^8.54.0",
"@typescript-eslint/parser": "^8.54.0",
"eslint-config-godaddy-react": "workspace:^",
"eslint-plugin-react-hooks": "^5.2.0"
},
"peerDependencies": {
"eslint": "^9",
"eslint": "^10",
"typescript": ">=5"
},
"devDependencies": {
"eslint": "^9.24.0"
"eslint": "^10.0.2"
},
"exports": {
".": "./index.js"
Expand Down
8 changes: 6 additions & 2 deletions packages/eslint-config-godaddy-react/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import gdConfig from 'eslint-config-godaddy';
import react from 'eslint-plugin-react';
import jsxA11y from 'eslint-plugin-jsx-a11y';

import { fixupConfigRules, fixupPluginRules } from '@eslint/compat';
Comment thread
rmarkins-godaddy marked this conversation as resolved.
import { FlatCompat } from '@eslint/eslintrc';
import path from 'path';
import { fileURLToPath } from 'url';
Expand All @@ -14,9 +15,12 @@ const compat = new FlatCompat({
baseDirectory: __dirname
});

// Wrap react plugin for ESLint 10 compatibility (context.getFilename etc.)
const reactCompat = fixupPluginRules(react);

const config = [
...gdConfig,
react.configs.flat.recommended,
...fixupConfigRules([react.configs.flat.recommended]),
// This is needed due to react-hooks not being Flat Config compatible there is an open
// issue for this https://github.com/facebook/react/issues/28313 and PR for this change
// https://github.com/facebook/react/pull/30774
Expand All @@ -33,7 +37,7 @@ const config = [
}
},
plugins: {
react,
react: reactCompat,
jsxA11y
},
rules: {
Expand Down
5 changes: 3 additions & 2 deletions packages/eslint-config-godaddy-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,11 @@
],
"peerDependencies": {
"@babel/core": ">=7",
"eslint": "^9"
"eslint": "^10"
},
"dependencies": {
"@babel/eslint-parser": "^7.27.0",
"@babel/eslint-parser": "^7.28.6",
"@eslint/compat": "^2.0.2",
"eslint-config-godaddy": "workspace:^",
"eslint-plugin-jsx-a11y": "^6.10.2",
"eslint-plugin-react": "^7.37.5",
Expand Down
8 changes: 4 additions & 4 deletions packages/eslint-config-godaddy-typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,16 @@
],
"license": "MIT",
"dependencies": {
"@typescript-eslint/eslint-plugin": "^8.35.0",
"@typescript-eslint/parser": "^8.30.1",
"@typescript-eslint/eslint-plugin": "^8.54.0",
"@typescript-eslint/parser": "^8.54.0",
"eslint-config-godaddy": "workspace:^"
},
"peerDependencies": {
"eslint": "^9",
"eslint": "^10",
"typescript": ">=5"
},
"devDependencies": {
"eslint": "^9.24.0"
"eslint": "^10.0.2"
},
"exports": {
".": "./index.js"
Expand Down
7 changes: 4 additions & 3 deletions packages/eslint-config-godaddy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,18 @@
"eslint"
],
"peerDependencies": {
"eslint": "^9"
"eslint": "^10"
},
"dependencies": {
"@eslint/js": "^10.0.0",
"eslint-plugin-jsdoc": "^50.6.9",
"eslint-plugin-json": "^4.0.1",
"eslint-plugin-mocha": "^10.5.0",
"globals": "^16.0.0"
},
"devDependencies": {
"@eslint/js": "^9.24.0",
"eslint": "^9.24.0"
"@eslint/js": "^10.0.0",
Comment thread
olafleur-godaddy marked this conversation as resolved.
Outdated
"eslint": "^10.0.0"
},
"exports": {
".": "./index.js"
Expand Down
Loading