feat: Phase 2 — browser skill-management HTTP endpoints (+ groups plumbing)

[aroff]

Two things: the groups follow-up from Phase 1, and Phase 2 of spec 003 (the HTTP endpoints).

groups plumbing (Phase-1 follow-up)

add_from_origin/commit now take a groups: Vec<String> and record it on the Manifest + Lock entry; an empty list on Update preserves the skill's existing groups. This deletes the CLI reapply_groups_after_seam workaround (add/update pass groups directly). Test covers record-on-add + preserve-on-update.

Phase 2 — browser skill-management HTTP surface (spec 003 §§1-4,6)

All endpoints run over the Phase-1 core seams, write-gated per ADR-0003 (403 without --enable-write):

• POST /skills/install {origin, groups?} → add_from_origin(Fresh) → 201, or 409 on an already-installed id, else 400/500.
• POST /skills/update {skill_id?, check?} → preflight + add_from_origin(Update). Replaces the old upgrade handler that shelled out to a subprocess. /skills/upgrade kept as an alias.
• POST /reindex[/{id}] → real service.reindex (was 501); returns 200 with reindexed:false when no embedding provider is configured (skip, not fail — ADR-0002). /reindex/{id} reindexes the whole index (core has no single-skill mode; documented).
• GET /status → adds writable + embedding_provider capability flags (the browser reads these to disable controls / show provider state — spec 003 §6).

Serve edge: execute_serve now builds its own service with inject_edge_services (embedding provider + repository manager) and with_project_root(<served project>), so HTTP installs write to the served project rather than the server's cwd — this closes, for the serve path, the Phase-1 cwd blocker (the core seam already took project_root; this wires it).

Review

The core seams (Phase 1) were opus-reviewed already. This HTTP layer was reviewed for: the ServiceError::AlreadyIndexed → 409 mapping (explicit, doesn't disturb the blanket →400 used elsewhere), the served-project-root resolution (via load_project_config at startup, injected once — not per-request cwd), write-gating of the three mutating routes, and that the injected service is the one the server actually uses. Clean.

Known limitations (documented, not blocking)

• /reindex/{id} reindexes the whole index (no single-skill reindex in core).
• --global installs remain CLI-only (the seam is project-level); the HTTP surface is project-scoped by design (spec 003 is local-first single-project).

Testing

• cargo build --workspace --all-targets ✅ · clippy --all-targets -D warnings ✅ · cargo test --workspace → 692 passed, 0 failed ✅
• New handler tests: install (201/409/400 + 403-without-write), update (200/check/404), reindex (200-skipped + 403), status capabilities. serve-command.mdx endpoint table updated.

Next: Phase 3 (the web UI — install flow over the four Origin variants, per-skill update/remove, read-only SKILL.md view). The HTTP surface it needs is now in place.

🤖 Generated with Claude Code